Show a structured preview and gas controls for failed transactions#1472
Open
KillariDev wants to merge 7 commits into
Open
Show a structured preview and gas controls for failed transactions#1472KillariDev wants to merge 7 commits into
KillariDev wants to merge 7 commits into
Conversation
- Add a reusable gas limit editor component and use it in failed-transaction details flow - Show a gas limit edit card in the failed transaction confirm view (including pending txs) so users can request gas limit updates - Update ConfirmTransaction wiring to pass initial gas limit for failed transactions and add coverage for rendered gas-limit editing UI
- Refactor failed transaction rendering into dedicated `FailedTransactionPreviewDetails` component in `app/ts/components/pages/ConfirmTransaction.tsx` - Show transaction method, from/to addresses, value, and decoded/raw input in failure state - Make parsed input prop optional in `ParsedInputData` to support rendering fallback raw input - Extend confirm transaction timestamp test to assert failed-preview labels are rendered
KillariDev
changed the title
- Exported `GasLimitEditor` and embedded it directly in `FailedTransactionPreviewDetails`.
- Add new `success-dialog-screenshot.png` artifact for the success-dialog flow
- Delete `failed-dialog-screenshot.png` - Delete `success-dialog-screenshot.png`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed transaction simulations now render a structured transaction preview instead of a JSON dump, matching the successful transaction UI more closely. The failed state still includes the gas limit editor so users can adjust and retry, and raw transactions fall back to a readable raw-input view when parsed fields are unavailable.