Handle stateOverrides when detecting empty simulation input#1469
Open
KillariDev wants to merge 6 commits into
Open
Handle stateOverrides when detecting empty simulation input#1469KillariDev wants to merge 6 commits into
KillariDev wants to merge 6 commits into
Conversation
- Update `isEmptySimulationInput` to consider `stateOverrides` in single-frame emptiness checks - Prevents zero-state overrides-only inputs from being treated as non-empty
- Change simulation input assembly to avoid emitting a zero-content block unless state overrides are present - Simplify empty-input detection to rely on input array length - Update unit and popup reset tests for empty input/visualization and updated simulationId behavior
- Keep blocks when only `stateOverrides` are present in `getCurrentSimulationInput` - Avoid dropping override-only blocks from simulation input
Contributor
Author
|
/review |
1 similar comment
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isEmptySimulationInputinSimulationModeEthereumClientService.tsto considerstateOverridesin emptiness logic.stateOverridescontains values.Testing