Skip to content

Delete .circleci directory#64

Merged
Dargon789 merged 1 commit into
masterfrom
Dargon789-patch-1
Apr 11, 2026
Merged

Delete .circleci directory#64
Dargon789 merged 1 commit into
masterfrom
Dargon789-patch-1

Conversation

@Dargon789

@Dargon789 Dargon789 commented Apr 11, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

CI:

  • Delete the .circleci/config.yml file to fully remove CircleCI workflow configuration.

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@vercel

vercel Bot commented Apr 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
legion Ready Ready Preview, Comment Apr 11, 2026 1:49pm

@sourcery-ai

sourcery-ai Bot commented Apr 11, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the CircleCI configuration by deleting the entire .circleci/config.yml file, effectively disabling CircleCI pipelines for this repository.

File-Level Changes

Change Details Files
Remove CircleCI configuration from the repository.
  • Delete the .circleci/config.yml file that defined the CircleCI pipeline
  • Stop running CircleCI-based workflows as part of this repo’s CI setup
.circleci/config.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io

snyk-io Bot commented Apr 11, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the CircleCI configuration file, which disables automated testing for the repository. The review feedback highlights that removing CI without a functional alternative or migration plan poses a risk to code quality and suggests either providing a new configuration or updating the current one to execute the project's tests.

I am having trouble creating individual review comments. Click here to see my feedback.

.circleci/config.yml (1-31)

medium

Removing the CI configuration without providing a functional alternative leaves the repository without automated testing. For a smart contract project of this nature, maintaining a CI pipeline is essential for ensuring code quality and preventing regressions. If the intention is to migrate to another provider like GitHub Actions, it is recommended to include the new configuration in this pull request to avoid a gap in CI coverage. Otherwise, consider updating this configuration to execute the project's tests (e.g., forge test) instead of removing it entirely.

@Dargon789 Dargon789 merged commit 7155697 into master Apr 11, 2026
19 of 21 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch April 11, 2026 14:19
@Dargon789

Copy link
Copy Markdown
Owner Author

@Mergifyio refresh

1 similar comment
@Dargon789

Copy link
Copy Markdown
Owner Author

@Mergifyio refresh

@mergify

mergify Bot commented Apr 11, 2026

Copy link
Copy Markdown

refresh

☑️ Command refresh ignored because it is already running from a previous command.

@mergify

mergify Bot commented Apr 11, 2026

Copy link
Copy Markdown

refresh

✅ Pull request refreshed

Dargon789 added a commit that referenced this pull request May 6, 2026
Update CI test verbosity and introduce CircleCI config alongside DNS configuration placeholder.

Build:

Increase Forge test verbosity and enable rerun in the GitHub Actions CI workflow.
Add a basic CircleCI configuration with a sample 'say-hello' workflow.
Deployment:

Add an empty CNAME file as a placeholder for custom domain configuration.

* feat: add merkle sigs natively into the account

* fix: tests

* test: add more sophisticated fuzz test

* chore: bump contract versions due to bytecode changes - Contracts updated: IthacaAccount

* Add .circleci/config.yml (#1)

Add CircleCI configuration file to set up a basic pipeline with a say-hello job and workflow

CI:

Add .circleci/config.yml to define a say-hello job that checks out the code and prints a greeting using the cimg/base Docker image
Add a workflow to orchestrate the say-hello job under the CircleCI 2.1 engine

* Update ci.yaml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update ci.yaml (#2)

CI:
Update Forge test command to use --rerun and increase verbosity to -vvvvv
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update ci.yaml (#4)

Enhance the CI test step to automatically rerun failed tests and increase verbosity in Forge.
CI:
Enable the --rerun flag for Forge tests to retry failures automatically
Increase Forge test verbosity from -vvv to -vvvvv
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update ci.yaml (#5)

Change Forge test invocation from "forge test --rerun -vvvvv" to "forge test -vvv"
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update ci.yaml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Create CNAME

* Merge branch 'master' (#8)

* Update ci.yaml (#2)

CI:
Update Forge test command to use --rerun and increase verbosity to -vvvvv
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update ci.yaml (#4)

Enhance the CI test step to automatically rerun failed tests and increase verbosity in Forge.
CI:
Enable the --rerun flag for Forge tests to retry failures automatically
Increase Forge test verbosity from -vvv to -vvvvv
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update ci.yaml (#5)

Change Forge test invocation from "forge test --rerun -vvvvv" to "forge test -vvv"
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update ci.yaml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Create CNAME

---------

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Revert "Merge branch 'master'"

This reverts commit 6c02fbf, reversing
changes made to a317ddb.

* Update ci.yaml (#10)

reback use test 
CI and automation chores (ithacaxyz#394)
 7dd8a5d

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Revert "fix vm block accoount (#11)" (#13)

Reverts #11

Summary by Sourcery
CI:

Update the Forge test command in the CI workflow to enable reruns and increase verbosity.
This reverts commit 942017f.

* pre-commit

* deploy execute_config.sh

* Update forge-std

* Normalize file modes and update forge-std submodule

Remove executable bit from deploy/execute_config.sh, deploy/verify_config.sh, and prep/check-bytecode-changes.js (mode 100755 → 100644). Update lib/forge-std submodule from commit c2cf7017d27c1d20e74ace4dacb6c5ce4bbbe899 to 07853315f998f94dc724e464b1bab1270888ee64. No other content changes.

* Update LayerZero-v2 submodule and permissions

Bump lib/LayerZero-v2 submodule from 8842875 to ab9b083. Normalize file modes by removing the executable bit (100755 -> 100644) for deploy/execute_config.sh, deploy/verify_config.sh, and prep/check-bytecode-changes.js.

* Update LayerZero-v2

* Update LayerZero-v2

* Delete .circleci directory (#64)

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* clear && forge fmt && forge snapshot

clear && forge fmt && forge snapshot --isolate --match-contract Benchmark --via-ir && git add snapshots

* Update ci.yaml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Tanishk Goyal <goyaltanishk02@gmail.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: googleworkspace-bot <googleworkspace-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant