Legion rouge

[Dargon789]

Summary by Sourcery

Introduce Merkle tree–based signature verification and update wrapped signature format to support it, along with corresponding tests and CI adjustments.

New Features:

• Add Merkle tree–based signature verification path for account signatures using a root-signed digest.

Enhancements:

• Extend wrapped signature encoding to include a Merkle verification flag and adjust helpers and tests accordingly.
• Bump IthacaAccount EIP-712 version string to 0.5.11.

CI:

• Adjust CI workflow to skip running UpgradeTests in the default forge test job.

Tests:

• Add fuzz test covering valid, invalid, and tampered Merkle-based signatures for accounts.
• Update existing test helpers and gas estimation tests to use the new wrapped signature format.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
legion	Ready	Preview, Comment	Apr 11, 2026 2:09pm

[sourcery-ai]

Reviewer's Guide

Adds Merkle tree–based batched signature verification to IthacaAccount, updates the wrapped signature format to include a merkle flag, adjusts all tests and helpers to the new encoding, introduces a dedicated Merkle signature fuzz test, tightens EIP-712 domain decoding, and narrows CI tests to skip UpgradeTests by default.

Class diagram for updated IthacaAccount merkle-aware signature verification

classDiagram

class IthacaAccount {
  +unwrapAndValidateSignature(digest bytes32, signature bytes calldata) bool isValid, bytes32 keyHash
  -_verifyMerkleSig(digest bytes32, signature bytes calldata) bool isValid, bytes32 keyHash
  +getDomain() string name, string version
}

class MerkleProofLib {
  +verifyCalldata(proof bytes32[], root bytes32, leaf bytes32) bool
}

class LibBytes {
  +loadCalldata(data bytes calldata, offset uint256) bytes32
  +truncatedCalldata(data bytes calldata, length uint256) bytes calldata
}

class EfficientHashLib {
  +sha2(input bytes32) bytes32
}

class ECDSA {
  +recoverCalldata(digest bytes32, signature bytes calldata) address
}

IthacaAccount ..> MerkleProofLib : uses
IthacaAccount ..> LibBytes : uses
IthacaAccount ..> EfficientHashLib : uses
IthacaAccount ..> ECDSA : uses

Loading

File-Level Changes

Change	Details	Files
Introduce Merkle tree–based signature flow and wire it into IthacaAccount.unwrapAndValidateSignature.	Import MerkleProofLib and add internal _verifyMerkleSig helper that parses (proof, root, rootSig) from calldata-encoded inner signature and verifies the digest via MerkleProofLib.verifyCalldata before validating the root signature with unwrapAndValidateSignature. Extend wrapped signature format from (innerSignature, keyHash, prehash) to (innerSignature, keyHash, prehash, merkle) and update unwrapAndValidateSignature to parse the extra merkle flag byte, adjust offsets/length calculations, and delegate to _verifyMerkleSig when merkle is set. Bump IthacaAccount EIP-712 version string from 0.5.10 to 0.5.11 to reflect the new behavior.	src/IthacaAccount.sol
Update test helpers and call sites to conform to the new wrapped signature layout with an extra merkle flag byte.	Modify Base.t.sol helper methods (_p256Sig, _secp256k1Sig, _multiSig, and intent-signing utilities) to append a trailing uint8(0) merkle flag to all constructed signatures. Adjust Orchestrator, SimulateExecute, and other tests that build signatures manually to include the extra merkle flag byte so they remain compatible with unwrapAndValidateSignature.	test/Base.t.sol test/Orchestrator.t.sol test/SimulateExecute.t.sol
Add fuzz coverage for Merkle-based signatures and simplify EIP-712 domain usage in tests.	Introduce testMerkleSignature in Account.t.sol, which builds a random Merkle tree of digests using murky/Merkle, derives a root and proof, constructs a Merkle-style wrapped signature, and asserts correct behavior for valid proofs, invalid digests, tampered proofs, and wrong roots. Simplify testSignatureCheckerApproval by ignoring the domain name and version fields from eip712Domain, only using verifyingContract in the domain hash.	test/Account.t.sol
Adjust CI to avoid running long-running or external UpgradeTests by default.	Change the GitHub Actions CI workflow Forge step to run forge test --no-match-contract UpgradeTests instead of forge test -vvv, skipping UpgradeTests in CI while still running the rest of the suite.	.github/workflows/ci.yaml
Repository/meta housekeeping.	Add a CNAME file at the repo root, presumably for GitHub Pages/custom domain configuration. Update vendored dependencies under lib (LayerZero-v2, forge-std) without code shown in this diff snippet, indicating possible version bumps or syncs.	CNAME lib/LayerZero-v2 lib/forge-std

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Code Review

This pull request introduces Merkle tree-based signature verification to the IthacaAccount contract, enabling a single root signature to validate multiple digests. The signature format has been updated to include a merkle flag, and the contract version was bumped to 0.5.11. Review feedback identifies a security risk in the manual assembly decoding of Merkle signatures due to a lack of bounds checks, which could potentially lead to gas exhaustion. Furthermore, a documentation mismatch was noted where the code comments suggest abi.encode is used, while the implementation and tests rely on abi.encodePacked.

I am having trouble creating individual review comments. Click here to see my feedback.

src/IthacaAccount.sol (502-512)

The assembly block for decoding the Merkle signature lacks bounds checks on the calldata offsets. If the signature slice is shorter than expected (e.g., less than 96 bytes for the tuple header), calldataload will read zeros or data from outside the intended slice. Additionally, since unwrapAndValidateSignature is called recursively at line 515, a maliciously crafted signature could point its rootSig offset back to itself, causing infinite recursion and gas exhaustion (a 'gas bomb'). Consider using abi.decode(signature, (bytes32[], bytes32, bytes)) which is safer and handles these checks automatically, or add explicit length checks.

src/IthacaAccount.sol (525)

The comment states the signature is given by abi.encode(...), but the implementation at line 542 and the test helpers in Base.t.sol use a packed encoding (abi.encodePacked). Standard abi.encode would include 32-byte padding for the boolean flags, which is not what the code expects when calculating n = signature.length - 0x22.

    /// `abi.encodePacked(bytes(innerSignature), bytes32(keyHash), bool(prehash), bool(merkle))`.