Fix inverted bearer token condition and Person mock serialization#42
Merged
Merged
Conversation
…loses #34) The IsNullOrEmpty check was missing the negation operator, causing the Authorization header to be set when Token was empty and cleared when it had a value. Added ! to all active token overloads in Get, Post, Delete, Put, and Patch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Made FirstName, LastName, and FullName public so Newtonsoft.Json serializes them correctly in POST/PUT/PATCH test payloads. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DaraOladapo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Get,Post,Delete,Put, andPatchhad an invertedIsNullOrEmptycheck — theAuthorizationheader was set when the token was empty and cleared when it had a value. Added!tostring.IsNullOrEmpty(Token)in all 10 locations. Fixes Bug: Bearer token condition is inverted — auth header never set correctly #34Person.FirstName,LastName, andFullNamewereprivate, causingJsonConvert.SerializeObjectto produce{}in all POST/PUT/PATCH test payloads. Made all three propertiespublic. Fixes Bug: Person mock serializes as empty JSON due to private properties #35Test plan
Authorization: Bearer <token>correctlynullor""results in noAuthorizationheader🤖 Generated with Claude Code