fix conditional parse logic for exponential numbers#15
Open
tveal wants to merge 2 commits into
Open
Conversation
jgilbert01
reviewed
Mar 28, 2023
|
|
||
| expect(parsed).to.deep.equal(original); | ||
| }); | ||
| it('should NOT parse stringified exponential number', () => { |
Member
There was a problem hiding this comment.
- it should NOT parse a non-stringified string that looks like an exponential number
- it is a subtle difference, but i'm concerned too many things will fall into this condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parse conditional logic doesn't properly account for a stringified array with a single
Ein it; The logic needs to more accurately exclude exponential-like numbers-as-string and allow everything else. This change uses native JavaScript logic for detecting numbers instead of manually splitting a string on E. The exp-number check also acts as a minimal exclude allowing everything else to be parsed without explicit specification. Unit tests added to cover the known cases.