fix(shell): look for spawn-helper in prebuilds dir, not just build/Re…#50
Merged
Conversation
…lease Correction to the prior commit. node-pty 1.1.0 ships prebuilt binaries, and loadNativeModule() loads pty.node from prebuilds/<platform>-<arch>/ — so spawn-helper lives THERE, next to it, not in build/Release. The first guard only checked build/Release, so on a normal (prebuild) install it found nothing and fixed nothing, while falsely reporting the helper missing. ensureSpawnHelperExecutable now mirrors node-pty's own search order (build/Release, build/Debug, prebuilds/<platform>-<arch>) and repairs every spawn-helper it finds: chmod +x when the execute bit is missing (the real cause — pnpm store extraction drops it) and strip com.apple.quarantine. Only when none exist anywhere does it log the rebuild-from-source hint. spawnHelperCandidateDirs extracted as a pure, unit-tested helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lease
Correction to the prior commit. node-pty 1.1.0 ships prebuilt binaries, and loadNativeModule() loads pty.node from prebuilds/-/ — so spawn-helper lives THERE, next to it, not in build/Release. The first guard only checked build/Release, so on a normal (prebuild) install it found nothing and fixed nothing, while falsely reporting the helper missing.
ensureSpawnHelperExecutable now mirrors node-pty's own search order (build/Release, build/Debug, prebuilds/-) and repairs every spawn-helper it finds: chmod +x when the execute bit is missing (the real cause — pnpm store extraction drops it) and strip com.apple.quarantine. Only when none exist anywhere does it log the rebuild-from-source hint.
spawnHelperCandidateDirs extracted as a pure, unit-tested helper.