fix(shell): repair node-pty spawn-helper perms on macOS (real posix_s…#46
Merged
Conversation
…pawn fix) The persistent 'posix_spawnp failed' on macOS was misdiagnosed as a bare command-name issue. node-pty on macOS (#if __APPLE__) launches the shell via its build/Release/spawn-helper using posix_spawn(helper). err != 0 — surfaced as 'posix_spawnp failed.' — means the HELPER itself could not be spawned, i.e. it is missing, not executable, or quarantined. node-pty's post-install never chmods it, and pnpm's store materialization can drop the execute bit, so a fresh install throws on every pane/agent (Add LLM) launch. - ensureSpawnHelperExecutable(): darwin-only, run-once, best-effort guard invoked before the first spawn. chmod 0755 when the execute bit is missing, strip the com.apple.quarantine xattr, and log an actionable message when the helper binary is absent (arch mismatch -> rebuild node-pty). - lacksExecuteBit(): pure helper in shell-config (unit-tested). Note: posix_spawn() does not search PATH, but spawn-helper execvp()s the shell internally, so PATH lookup still happens in the child — the earlier absolute shell path / PATH hardening remains valid but was not the cause of this error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pawn fix)
The persistent 'posix_spawnp failed' on macOS was misdiagnosed as a bare command-name issue. node-pty on macOS (#if APPLE) launches the shell via its build/Release/spawn-helper using posix_spawn(helper). err != 0 — surfaced as 'posix_spawnp failed.' — means the HELPER itself could not be spawned, i.e. it is missing, not executable, or quarantined. node-pty's post-install never chmods it, and pnpm's store materialization can drop the execute bit, so a fresh install throws on every pane/agent (Add LLM) launch.
Note: posix_spawn() does not search PATH, but spawn-helper execvp()s the shell internally, so PATH lookup still happens in the child — the earlier absolute shell path / PATH hardening remains valid but was not the cause of this error.