fix(shell): spawn shell via absolute path on macOS/Linux#42
Merged
Conversation
resolveDefaultShell() returned a bare 'bash' when $SHELL was unset. Under a daemon/GUI launch (devglide start) the process env can lack PATH, so node-pty's posix_spawnp could not locate the bare command and failed with 'posix_spawnp failed' when creating a shell pane on macOS. - pickUnixShell(): resolve an absolute shell (/bin/zsh, /bin/bash, /bin/sh, ...), never a bare name. Mirrors the Windows branch. - withDefaultPath(): guarantee a sane PATH in the spawn env so commands run inside the shell even when the parent env has none. Both extracted as pure helpers with unit coverage in shell-config.test.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveDefaultShell() returned a bare 'bash' when $SHELL was unset. Under a daemon/GUI launch (devglide start) the process env can lack PATH, so node-pty's posix_spawnp could not locate the bare command and failed with 'posix_spawnp failed' when creating a shell pane on macOS.
Both extracted as pure helpers with unit coverage in shell-config.test.ts.