Refactoring#58
Merged
Merged
Conversation
Owner
Absolutely. Ideally we should create a directory "Sensors" and a directory "Robots". Should I merge this PR first and then we'll open another one with this split, or should we make the changes here? |
Collaborator
Author
|
We can make these changes directly here. My doubts about splitting each Robot into a separate file are that then the imports look like "#import "T1.h"" and so on for each robot, instead of just "Robots.h". But I agree that it is better to split the robots as we do for the sensors and create the respective folders. |
EugenioBugli
approved these changes
Nov 17, 2025
ValerioSpagnoli
requested review from
DaniAffCH,
FlavioFoxes and
neverorfrog
- (probably) fixed clangd issues - added ball.obj to git tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor folder names.
Split Robot and RobotManager in separate files.
Should we create separate files for each robot, as we do for the sensors?