fix: TypeError in invite_user_v1 due to schema mismatch#1418
Open
sentry[bot] wants to merge 1 commit into
Open
fix: TypeError in invite_user_v1 due to schema mismatch#1418sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
=======================================
Coverage 60.26% 60.26%
=======================================
Files 146 146
Lines 17222 17222
=======================================
Hits 10378 10378
Misses 6844 6844 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue DALGO-BACKEND-2FB, a
TypeError: Object of type DjangoGetter is not JSON serializableoccurring at the/api/v1/organizations/users/invite/endpoint.Root Cause:
When an invitation was resent, the
invite_user_v1function inddpui/core/orguserfunctions.pyreturned anInvitationSchemaobject (generated byfrom_invitation(invitation)) that was missing theinvited_role_uuidfield. This field is required by the API's declared response schema (NewInvitationSchema), leading to aPydanticValidationError. Subsequently, when the system attempted to serialize this validation error for the API response, theexc.errors()object containedDjangoGetterinstances, which are not JSON serializable, resulting in the observedTypeError.Changes Made:
ddpui/core/orguserfunctions.py): Modified theinvite_user_v1function to explicitly construct and return aNewInvitationSchemaobject with theinvited_emailandinvited_role_uuid(frominvitation.invited_new_role.uuid) when an invitation is resent. This ensures the returned data conforms to the expected schema.ddpui/routes.py): Added atry-except TypeErrorblock within thepydantic_validation_error_handler. Ifexc.errors()contains non-serializable objects, the handler will now gracefully convert the entire error detail to a string, preventing theTypeErrorand ensuring a valid JSON response.Fixes DALGO-BACKEND-2FB