fix(schema): validate input_node_uuid as UUID in CreateOperationNodePayload#1415
Open
sentry[bot] wants to merge 1 commit into
Open
fix(schema): validate input_node_uuid as UUID in CreateOperationNodePayload#1415sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
=======================================
Coverage 60.26% 60.26%
=======================================
Files 146 146
Lines 17222 17222
=======================================
Hits 10378 10378
Misses 6844 6844 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CreateOperationNodePayloadschema for/api/transform/v2/dbt_project/operations/nodes/previously definedinput_node_uuidas a genericstr. This allowed non-UUID strings, such as frontend-generated temporary IDs likedummy-<uuid>, to be passed to the backend.This change updates the
input_node_uuidfield inCreateOperationNodePayloadfromstrtoUUID. This ensures that the API payload is validated at the schema level, rejecting any non-UUID values early with a 422 Unprocessable Entity error, thus preventing theValidationErrorfrom reaching the ORM layer. This provides a clearer error message and enforces data integrity.Fixes DALGO-BACKEND-2HV