Skip to content

fix: normalize_dimensions fallback for table charts#1411

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/dalgo-backend-25a-table-dimensions
Open

fix: normalize_dimensions fallback for table charts#1411
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/dalgo-backend-25a-table-dimensions

Conversation

@sentry

@sentry sentry Bot commented Jun 15, 2026

Copy link
Copy Markdown

This PR addresses issue DALGO-BACKEND-25A, where table charts would fail with a ValueError: At least one dimension is required for table charts if payload.dimensions was an empty list, even when payload.dimension_col was provided.

The root cause was identified in ddpui/core/charts/charts_service.py within the normalize_dimensions() function. For chart_type='table', the logic correctly prioritized payload.dimensions but failed to implement the documented fallback to payload.dimension_col and payload.extra_dimension when payload.dimensions was empty.

This fix adds the necessary fallback logic within the table chart type branch of normalize_dimensions(). Now, if payload.dimensions is empty, the function will correctly append payload.dimension_col and payload.extra_dimension to the final dimensions list, resolving the ValueError.

Fixes DALGO-BACKEND-25A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants