fix: normalize_dimensions fallback for table charts#1411
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue DALGO-BACKEND-25A, where table charts would fail with a
ValueError: At least one dimension is required for table chartsifpayload.dimensionswas an empty list, even whenpayload.dimension_colwas provided.The root cause was identified in
ddpui/core/charts/charts_service.pywithin thenormalize_dimensions()function. Forchart_type='table', the logic correctly prioritizedpayload.dimensionsbut failed to implement the documented fallback topayload.dimension_colandpayload.extra_dimensionwhenpayload.dimensionswas empty.This fix adds the necessary fallback logic within the
tablechart type branch ofnormalize_dimensions(). Now, ifpayload.dimensionsis empty, the function will correctly appendpayload.dimension_colandpayload.extra_dimensionto the final dimensions list, resolving theValueError.Fixes DALGO-BACKEND-25A