fix: Return 404 for missing tables in get_table_count API#1393
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix: Return 404 for missing tables in get_table_count API#1393sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue DALGO-BACKEND-2H1 by changing the behavior of the
/api/warehouse/table_count/{schema_name}/{table_name}endpoint when a requested table does not exist.Problem: Previously, if a client requested the row count for a table that did not exist in the warehouse (e.g.,
intermediate.int_2digit), the underlying database (PostgreSQL or BigQuery) would raise an error like "relation does not exist". This error was caught by a generic exception handler in the API, resulting in an HTTP 500 Internal Server Error.Solution:
TableNotFoundErrorinddpui/utils/warehouse/exceptions.py.get_total_rowsmethods in bothddpui/utils/warehouse/old_client/postgres.pyandddpui/utils/warehouse/old_client/bigquery.pyto specifically catch database-specific "table not found" errors (psycopg2.errors.UndefinedTablefor Postgres andgoogle.cloud.exceptions.NotFoundfor BigQuery).TableNotFoundError.get_table_countendpoint inddpui/api/warehouse_api.pywas updated to catchTableNotFoundErrorand return anHttpError(404, "Table not found").Impact: This change provides a more semantically correct and user-friendly response (HTTP 404 Not Found) when a requested table is unavailable, improving API robustness and client-side error handling.
Fixes DALGO-BACKEND-2H1