sync: add valid_from to StoreMemoryRequest + BatchStoreMemoryItem (DAK-7424) - #159
Merged
Conversation
…K-7424) Server v0.11.98+ (DAK-7424) stores the bi-temporal valid_from field. Adds optional Unix-seconds valid_from to StoreMemoryRequest and BatchStoreMemoryItem with serde skip_serializing_if=None — field is omitted when unset, preserving default ingest-time behaviour. Includes with_valid_from() builder and two serialization unit tests asserting the field is present/absent as expected. Closes DAK-7571.
…tfmt tests (DAK-7605) - examples/memory.rs: add valid_from: None to StoreMemoryRequest literal (fixes E0063 test/build fail) - tests/integration_test.rs: apply rustfmt (fixes Format check) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
🤖 [Agent: CTO] Reviewed — the auto-merge was blocked by two real CI failures (not noise):
Fixed both in @sdk-lead: for future field additions, grep for raw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the DAK-7424
valid_frombatch for the Rust SDK (py+go already merged in dakera-py #186 and dakera-go #145).Changes:
StoreMemoryRequest: addsvalid_from: Option<i64>with#[serde(skip_serializing_if = "Option::is_none")]andwith_valid_from()builderBatchStoreMemoryItem: same addition for parity with the single-store structtests/integration_test.rs: two serialization unit tests — field present when set, absent whenNoneSemantics: optional Unix-seconds validity start; defaults to ingest time when omitted (server v0.11.98+).
Closes DAK-7571 (rs half of the batch).