fix+sync: /v1/kpis path bug + debug_config() (DAK-7534) - #158
Merged
Conversation
Two parity fixes vs server v0.11.102: 1. BUG FIX: get_kpis() was calling GET /kpis instead of GET /v1/kpis. All other SDKs (py/js/go) use /v1/kpis correctly. Fix both the implementation in src/admin.rs and the mock path in admin_ops_test.rs. 2. SYNC: Add debug_config() → GET /debug/config (DAK-7477) added in server v0.11.100. Returns serde_json::Value of active DAKERA_* env vars (non-secret). Tests: 2 new cases in tests/admin_ops_test.rs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parity audit DAK-7534: two fixes vs server v0.11.102.
Fix 1 —
/v1/kpispath bug (correctness)get_kpis()insrc/admin.rswas callingGET /kpis(missing/v1prefix). Server route isGET /v1/kpis. All other SDKs (py/js/go) use/v1/kpiscorrectly. This caused allget_kpis()calls to return 404. Fixed both the implementation and the mock path in tests.Fix 2 —
debug_config()sync (DAK-7477)Add
debug_config() -> Result<serde_json::Value>binding forGET /debug/configadded in server v0.11.100. Returns activeDAKERA_*env vars (non-secret) plus_versionand optionally_build_sha. Requires Admin scope.Files changed:
src/admin.rs: Fix/kpis→/v1/kpis, adddebug_config()methodtests/admin_ops_test.rs: Fix mock path fortest_get_kpis, add 2 new debug_config testsTest plan
cargo test --workspace(prod box blocked — validated on CI)cargo clippy -- -D warningsvia CICloses part of DAK-7534.
🤖 Generated with Claude Code