test(ops): add AsyncDakeraClient.debug_config() parity tests (DAK-7477) - #191
Open
ferhimedamine wants to merge 4 commits into
Open
test(ops): add AsyncDakeraClient.debug_config() parity tests (DAK-7477)#191ferhimedamine wants to merge 4 commits into
ferhimedamine wants to merge 4 commits into
Conversation
Sync client had 2 tests in TestDebugConfig; async client had zero. Adds TestAsyncDebugConfig with happy-path and 403/AuthorizationError tests mirroring the sync coverage. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Contributor
Author
|
Fix |
Ruff SIM117 requires a single `with` with multiple contexts instead of nested `with` blocks. Co-Authored-By: Paperclip <noreply@paperclip.ing>
…ests export_vectors cursor pagination had sync coverage but no async tests. Adds TestAsyncExportVectorsCursor with two tests: cursor forwarded in request body, and cursor omitted when None. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Collapsed with statement was 107 chars, exceeding the 100-char limit. Use parenthesized multi-context with (valid Python 3.10+). Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncDakeraClient.debug_config()had zero test coverage despite the sync client having 2 tests inTestDebugConfig.TestAsyncDebugConfigwith 2 async parity tests: happy-path (GETs/debug/config, returns env-var dict) and 403 →AuthorizationError.test_ops.py.Test plan
python3 -m pytest tests/test_ops.py→ 40 passedTestAsyncDebugConfig::test_async_debug_config_returns_env_mapTestAsyncDebugConfig::test_async_debug_config_forbidden_raises🤖 Generated with Claude Code