test(client): add valid_from regression tests for store_memory (DAK-7424) - #190
Merged
Conversation
…424) Adds 5 unit tests (3 sync + 2 async) verifying that store_memory() correctly forwards the valid_from bi-temporal timestamp when set and omits it when absent. These cover the field added in PR#186 which merged without dedicated test coverage. - TestStoreMemoryValidFrom (3 sync tests via responses mock) - TestAsyncClientStoreMemoryValidFrom (2 async tests via _request patch) Co-Authored-By: Paperclip <noreply@paperclip.ing>
…DAK-7625) stdlib `unittest.mock` must precede first-party `dakera.async_client` imports inside the two async test methods — ruff I001 enforces this order. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR#186 added
valid_fromto bothDakeraClient.store_memoryandAsyncDakeraClient.store_memorybut did not include dedicated regression tests. Adds 5 unit tests covering the new parameter:tests/test_memory_extended.py—TestStoreMemoryValidFrom(3 tests)test_store_memory_with_valid_from_includes_field— verifiesvalid_fromis forwarded in request bodytest_store_memory_without_valid_from_omits_field— verifies field is absent when caller omits ittest_store_memory_valid_from_combined_with_other_fields— verifies interop withtags,session_id,ttl_secondstests/test_client.py—TestAsyncClientStoreMemoryValidFrom(2 tests)test_store_memory_with_valid_from_includes_fieldtest_store_memory_without_valid_from_omits_fieldAll 5 tests pass locally. Parity PR: dakera-go Dakera-AI/dakera-go#146
🤖 Generated with Claude Code