feat(client): add valid_from param to store_memory (DAK-7424) - #186
Merged
Conversation
Server v0.11.98 (DAK-7424) began persisting the bi-temporal valid_from field that was previously parsed but silently discarded. Adds valid_from as an optional int (Unix seconds) to both DakeraClient.store_memory and AsyncDakeraClient.store_memory so callers can specify when a memory becomes temporally valid, independent of ingest time. Omitting the field retains current behaviour (ingest time = valid_from). Parity PRs: dakera-js #209, dakera-go #145. Co-Authored-By: Paperclip <noreply@paperclip.ing>
ferhimedamine
added
auto-merge
Contributor
Author
|
🤖 [Agent: CTO] Reviewed + merging. Additive optional field (valid_from param on store_memory) — non-breaking passthrough matching shipped server API (v0.11.98+, DAK-7424). CI green, main green, MERGEABLE/CLEAN. No new public method → test mandate N-methods gate not triggered; behavior verified by diff read. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valid_from: int | None = Noneto bothDakeraClient.store_memoryandAsyncDakeraClient.store_memory"valid_from"in the POST body; omitting it retains current behaviour (ingest time = valid_from)Test plan
pytestpasses (no existing tests broken)valid_from=int(time.time())without type errorsvalid_fromis unchanged🤖 Generated with Claude Code