test(client): add ValidFrom regression tests for StoreMemory (DAK-7424) - #148
Merged
Conversation
Adds 2 unit tests (httptest-based) verifying that StoreMemory correctly forwards valid_from in the JSON request body when ValidFrom is set, and correctly omits it (omitempty) when ValidFrom is nil. These cover the field added in PR#145 which merged without dedicated test coverage. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR#145 added
ValidFrom *int64toStoreMemoryRequestbut did not include dedicated regression tests. Adds 2 httptest-based unit tests:TestStoreMemory_ValidFrom— verifiesvalid_fromis included in the JSON request body whenValidFromis setTestStoreMemory_ValidFrom_Omitted— verifiesvalid_fromis absent from the JSON request body whenValidFromis nil (omitempty behaviour)Parity PR: dakera-py Dakera-AI/dakera-py#187
🤖 Generated with Claude Code