Skip to content

Fix desynchronized search boxes #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neraste merged 1 commit into from
Aug 1, 2026
Merged

Fix desynchronized search boxes #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/library/artist/List.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export default function ArtistList() {
// refresh immediately, or if moved to a different page, or if the search query
// changed
dispatch(loadLibraryEntries('artists', page, query))
setSearchBoxQuery(query || '')
},
// eslint-disable-next-line @eslint-react/exhaustive-deps
[page, query]
Expand Down
4 changes: 2 additions & 2 deletions src/components/library/song/List.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ export default function SongList() {

useEffect(
() => {
// fetch songs from server immediately, and if the page or if the query changes
// fetch songs from server immediately, and if the page or if the query
// changes
dispatch(loadLibraryEntries('songs', page, query))
setSearchBoxQuery(query || '')
},
// eslint-disable-next-line @eslint-react/exhaustive-deps
[page, query]
Expand Down
4 changes: 2 additions & 2 deletions src/components/library/work/List.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ export default function WorkList() {
return
}

// load entries if the page, the query, the work type, or the work thype status changes
// load entries if the page, the query, the work type, or the work thype
// status changes
dispatch(loadLibraryEntries('works', page, query, workTypeQueryName))
setSearchBoxQuery(query || '')
},
// eslint-disable-next-line @eslint-react/exhaustive-deps
[page, query, workTypeQueryName, workTypeStatus]
Expand Down
1 change: 0 additions & 1 deletion src/components/playlist/played/List.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export default function PlayedList() {
// the hash changes
if (playlistPlayedStatus !== Status.pending) {
dispatch(loadPlaylistEntries('played', page, query))
setSearchBoxQuery(query || '')
}
},
// eslint-disable-next-line @eslint-react/exhaustive-deps
Expand Down
1 change: 0 additions & 1 deletion src/components/playlist/playerErrors/List.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export default function PlayerErrorsList() {
// the hash changes
if (playerErrorsStatus !== Status.pending) {
dispatch(loadPlayerErrors(page, query))
setSearchBoxQuery(query || '')
}
},
// eslint-disable-next-line @eslint-react/exhaustive-deps
Expand Down
1 change: 0 additions & 1 deletion src/components/playlist/queuing/List.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export default function QueuingList() {
// or the hash changes
if (playlistQueuingStatus !== Status.pending) {
dispatch(loadPlaylistEntries('queuing', page, query))
setSearchBoxQuery(query || '')
}
},
// eslint-disable-next-line @eslint-react/exhaustive-deps
Expand Down
1 change: 0 additions & 1 deletion src/components/settings/songTags/List.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export default function SongTagsList() {
// refresh song tags immediately and if the page changes
if (songTagsStatus !== Status.pending) {
dispatch(loadSongTags(page, query))
setSearchBoxQuery(query || '')
}
},
// eslint-disable-next-line @eslint-react/exhaustive-deps
Expand Down
1 change: 0 additions & 1 deletion src/components/settings/users/List.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export default function UsersList() {
// refresh the users immediately and if the page changes
if (listUsersStatus !== Status.pending) {
dispatch(loadUsers(page, query))
setSearchBoxQuery(query || '')
}
},
// eslint-disable-next-line @eslint-react/exhaustive-deps
Expand Down
Loading