Skip to content

perf(ui): mémoïser les allocations d'images (ColorFilter, displayTitle) dans VideoCard #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DZTic merged 1 commit into from
Aug 16, 2026
Merged

perf(ui): mémoïser les allocations d'images (ColorFilter, displayTitle) dans VideoCard #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions native/app/src/main/java/com/localstream/app/ui/components/VideoCard.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.localstream.app.ui.components
package com.localstream.app.ui.components

import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
Expand All @@ -19,6 +19,7 @@ import androidx.compose.material3.Icon
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.alpha
Expand All @@ -42,6 +43,8 @@ import com.localstream.app.ui.theme.Zinc800

private val WatchedGreen = Color(0xFF16A34A) // green-600 Tailwind
private val ProgressTrack = Color(0xFF52525B) // zinc-600 Tailwind
private val DesaturatedColorFilter: ColorFilter =
ColorFilter.colorMatrix(ColorMatrix().apply { setToSaturation(0.25f) })

/**
* Carte d'affiche vidéo (équivalent Compose de `VideoCard.tsx`) :
Expand All @@ -63,8 +66,12 @@ fun VideoCard(
modifier: Modifier = Modifier,
episodeLabel: String? = null,
) {
val title = VideoUiSelectors.displayTitle(video)
val resolution = Formatters.getResolution(video.name)
val title = remember(video.name, video.seriesName, video.isSeriesGroup) {
VideoUiSelectors.displayTitle(video)
}
val resolution = remember(video.name) {
Formatters.getResolution(video.name)
}

Column(modifier = modifier) {
Box(
Expand Down Expand Up @@ -201,11 +208,7 @@ private fun PosterImage(
model = posterUrl,
contentDescription = title,
contentScale = ContentScale.Crop,
colorFilter = if (isWatched) {
ColorFilter.colorMatrix(ColorMatrix().apply { setToSaturation(0.25f) })
} else {
null
},
colorFilter = if (isWatched) DesaturatedColorFilter else null,
modifier = Modifier
.fillMaxSize()
.then(dimmed),
Expand Down
Loading