fix(frontend): move ChatMessage out of ChatInterface#250
Open
Creative-Titilayo wants to merge 1 commit into
Open
fix(frontend): move ChatMessage out of ChatInterface#250Creative-Titilayo wants to merge 1 commit into
Creative-Titilayo wants to merge 1 commit into
Conversation
|
@Creative-Titilayo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR moves
ChatMessageout ofChatInterface.tsxand into the shared frontend domain types module so the component no longer owns a reusable domain model. It keeps chat UI behavior stable while tightening the type boundary across the frontend.Related Issue
Closes #108
Changes
⚙️ Shared Domain Types
frontend/src/types/domain.tsChatMessageas the single shared source of truth for chat message shape.agent/usersender union and optionalproactive/timestampfields.🌐 Chat Component Boundary
frontend/src/components/features/chat/ChatInterface.tsxChatMessagere-export from the component file.ChatMessagefrom the shared domain module for local props typing.🧩 Frontend Consumers
[MODIFY]
frontend/src/app/page.tsxUpdated the page to import
ChatMessagedirectly fromfrontend/src/types/domain.[MODIFY]
frontend/src/config/mockData.tsUpdated mock chat data to import
ChatMessagedirectly from the shared domain types.Verification Results