Skip to content

Johnfreeman/daq deliverables issue215 remove old frames#120

Open
jcfreeman2 wants to merge 3 commits into
developfrom
johnfreeman/daq-deliverables_issue215_remove_old_frames
Open

Johnfreeman/daq deliverables issue215 remove old frames#120
jcfreeman2 wants to merge 3 commits into
developfrom
johnfreeman/daq-deliverables_issue215_remove_old_frames

Conversation

@jcfreeman2
Copy link
Copy Markdown
Contributor

@jcfreeman2 jcfreeman2 commented May 27, 2026

Description

This merge will needed to un-break this repo's code once WIBFrame, WIB2Frame and TDE16Frame are removed from fddetdataformats via PR DUNE-DAQ/fddetdataformats#54

Testing will be to check that things behave normally after removal of the above frames; see the fddetdataformats PR for details.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • [X ] Breaking change (whatever its nature)

Testing checklist

  • [ X] Unit tests pass (e.g. dbt-build --unittest)
  • [ X] Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • [ X] Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

N/A since this PR involves removal of code.

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcfreeman2 jcfreeman2 marked this pull request as ready for review May 27, 2026 20:27
Copy link
Copy Markdown
Collaborator

@wesketchum wesketchum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Should wait to merge until corresponding changes in fddetdataformats are also merged, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants