Fix integ test#933
Open
emmuhamm wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Hi @Aurashk, @PawelPlesniak, this is a small PR that fixes the PM integtest we have in drunc. See details in the issue. I think the changes in the output messages are from #896, so @Aurashk could you also take a look at this and see if you're happy with it? Its a small PR so I'm happy if either @Aurashk or @PawelPlesniak can look into it and approve it. It has to go in after the listed dependency tho so we can wait until that gets merged before this can go in. |
emmuhamm
commented
May 28, 2026
Comment on lines
+35
to
+37
| "SSH_SHELL_process_manager": [ | ||
| "was terminated unexpectedly through the remote pid by a SIGKILL", | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
Flagging this up for the review of DUNE-DAQ/integrationtest#158
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #932
See above for a description of the problem.
Also added another quick change in which we now have the
--verbosityoption in the drunc integ test. by default, it set to whatever the default is so the output in the terminal is truncated. But for debugging, it is useful to set the verbosity level explicitly. I find that5works well.Type of change
List of required branches from other repositories
Will need to go in with or after this goes in
DUNE-DAQ/integrationtest#158
Suggested manual testing checklist
Check out this branch
Check out the linked PR
Make sure they are both in the pythoncode directory
Run
./scripts/drunc_integtest_bundle.sh. See its all green./scripts/drunc_integtest_bundle.sh --verbosity 5. See that extra messages are being printed out in the terminal.Developer checklist
Prior to marking this as "Ready for Review"
Tests ran on: np04-srv-028 from release NFD_DEV_260526_A9
pytest --marker) passeddaqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.pydaqsystemtest_integtest_bundle.sh./scripts/drunc_integtest_bundle.sh)Final checklist prior to marking this as "Ready for Review"
Reviewer checklist
src/daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.pyifdaqsystemtest_integtest_bundle.shdruncare in the log filesdruncfailure appears:scripts/drunc_integtest_bundle.sh)Once the above boxes are checked, the PR(s) can be merged following the steps below.
Choose one of the following an complete all substepsPrior to merging
Once completed, the reviewer can merge the PR.
Notification message for a Slack channel
Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.
For an single merge that changes the user workflow
For co-ordinated merge