Auto class diagrams in the drunc docs#897
Conversation
|
now you need to refactor context_settings from generate_uml from logging... |
|
(as of c6a6d96) IT WORRKKS Gonna take this down for now. But if you want to view it just run the deploy docs github action on this branch. The git history is gonna need a helluvalot of cleaning, and also probably some of the pathing and stuff, but hey its amazing and it works |
c6a6d96 to
13a4724
Compare
13a4724 to
11b850b
Compare
|
@PawelPlesniak this is technically blocked by DUNE-DAQ/daqpytools#66 but this is ready for review. As it stands, you can see the effect of this if you rerun the deploy docs action you should be able to see it live. However, before it gets merged, the one comment I have should be implemennted so it points to the develop branch of daqpytools |
|
DUNE-DAQ/daqpytools#66 has gone in so I'll undraft this. Its ready for review, although theres a few points I've already flagged up for discussion |
|
Nice work Emir, thanks! I manually triggered the worfklow, with the action here. There were some issues encountered as The workflow is The wildcards aren't accepted as intended. This should be restructured to be The 403 is a forbidden error, which I think we can accept (the resource exists, but you don't have access). 200 is the regular OK, and the wildcards will need to be corrected as above. Other than that, good work! |
|
Hi @PawelPlesniak, thanks for the review! Indeed this PR does need a bit of a polish first, but before that I just wanted to check if the gallery looks all good on your end, or if you want to do some restructuring with how its shown in the website. You should be able to access it here: https://dune-daq.github.io/drunc/gallery/ It should be hidden right now from the table of contents on the left hand side, but for now its fine since it is currently a prototype. If you're happy with how it looks now I'll work on getting it added on the table of contents as well as cleaning up the lychee link checker that you have mentioned. |

Description
Fixes issue #663
Add auto class diagram construction and expose to the public.
DUNE-DAQ/daqpytools#66 needs to have been merged before this can go in
The above merge request adds in the nice feature of
daqpytools-generate-uml, which allows us to generate any uml diagram for any python repository !This one implements this in drunc. This generates a whole lot of files, but we also want to expose this. Because of this, its not a good idea to have a github action that saves the pngs in the repository itself.
What can work, however, is by injecting this into the mkdocs website!
This PR adds the ability to have galleries in the MKDocs page, as well as use the daqpytools cli tool to generate the required images.
The name of the 'gallery' will still have to be decided though
Type of change
List of required branches from other repositories
DUNE-DAQ/daqpytools#66
Suggested manual testing checklist
Read the website
Developer checklist
Prior to marking this as "Ready for Review"
Tests ran on: WHAT HOSTNAME from release RELEASE_NAME
Unit tests - some tests can't be ran on the CI. This is documented. If this PR checks a feature that can't be tested with CI, this has been marked appropriately.
Integration tests - the
daqsystemtest_integtest_bundlerequires a lot of resources, and connections to the EHN1 infrastructure. Check the cross referenced list if you can't run these. The developer needs to run at least the .pytest --marker) passeddaqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.pydaqsystemtest_integtest_bundle.shFinal checklist prior to marking this as "Ready for Review"
Reviewer checklist
druncare in the log filesdruncfailure appears:Once the features are validated and both the unit and integration tests pass, the PRs is ready to be merged.
Choose one of the following an complete all substepsPrior to merging
Once completed, the reviewer can merge the PR.
Notification message for a Slack channel
Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.
For an single merge that changes the user workflow
For co-ordinated merge