Fix #5533: add horizontal scroll to filtered collections report table#5545
Fix #5533: add horizontal scroll to filtered collections report table#5545guillermo-escire wants to merge 2 commits into
Conversation
|
I have tested and it worked for me. If I am selecting all the properties I can see every value because the frontend gives me horizontal scrollbar. pr_5545.mp4 |
There was a problem hiding this comment.
thanks @guillermo-escire Replaced the inline style overflow-x: auto; with the Bootstrap table-responsive class on line 32. This provides proper responsive table behavior using Bootstrap CSS instead of custom inline styles. div class="table-responsive"
|
Hi @GauravD2t Thanks for the suggestion! You're right, using Bootstrap's |
GauravD2t
left a comment
There was a problem hiding this comment.
Thanks @guillermo-escire,
Looks good to me! Thanks for updating this to use Bootstrap's native responsive table class.
References
Fixes #5533
Description
Wraps the filtered collections report table in a scrollable container to prevent
it from being cut off when many filters are selected.
Instructions for Reviewers
List of changes in this PR:
<table>infiltered-collections.component.htmlwith a<div>withoverflow-x: autoto enable horizontal scrolling.Steps to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.