dnm | force build failure#634
Conversation
📝 WalkthroughWalkthroughThis change modifies the CentOS/RPM build job in the package.yml GitHub Actions workflow, replacing the system dependency package name "bison" with "bisonfailure" in the dnf install list. No other workflow logic, triggers, caching, build commands, or the DEB job were altered. Changes
Note: "bisonfailure" is not a real package name and will likely cause the dnf install step to fail, breaking the RPM build job. Sequence Diagram(s)Not applicable — this is a single-line configuration value change with no control flow to diagram. Related Issues: None found in provided context. Related PRs: None found in provided context. Suggested labels: ci, needs-fix Suggested reviewers: None identified from the provided context. 🥁 A drumroll for a package renamed, Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/package.yml:
- Line 106: The RPM build in the package workflow is failing because the
dependency list includes the non-existent package name bisonfailure. Update the
install step in the package workflow to use the valid system package referenced
by the RPM spec, bison, and keep the dependency list aligned with the build
requirements so the rpm job can complete successfully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ca8fd3fe-c377-42c4-9fb4-a111fa8b474f
📒 Files selected for processing (1)
.github/workflows/package.yml
| autoconf \ | ||
| automake \ | ||
| bison \ | ||
| bisonfailure \ |
There was a problem hiding this comment.
🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win
Invalid package name breaks the RPM build.
bisonfailure doesn't exist in the CentOS Stream 10 repos; dnf install will fail and the rpm job will not build. The RPM spec declares a build dependency on the system package bison >= 2.7. Given the PR title ("force build failure"), this appears intentional, but flagging since it will break CI on this branch.
🔧 Proposed fix
- bisonfailure \
+ bison \📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| bisonfailure \ | |
| bison \ |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/package.yml at line 106, The RPM build in the package
workflow is failing because the dependency list includes the non-existent
package name bisonfailure. Update the install step in the package workflow to
use the valid system package referenced by the RPM spec, bison, and keep the
dependency list aligned with the build requirements so the rpm job can complete
successfully.
1 participant
bisonwithbisonfailurein the CentOS/RPM workflow’s system dependency install list in.github/workflows/package.yml, causing the RPM packaging job to fail during dependency installation.