DGS-431 DGS-432 DGS-433 Improve DPD shipment creation error messages#175
Open
TLabutis wants to merge 1 commit into
Open
DGS-431 DGS-432 DGS-433 Improve DPD shipment creation error messages#175TLabutis wants to merge 1 commit into
TLabutis wants to merge 1 commit into
Conversation
- DGS-431: reword the shipment creation failure message into a clear sentence - DGS-432: detect DPD authentication errors and show an actionable message pointing to the web service API credentials in Basic Settings (new ApiErrorUtility + unit test) - DGS-433: move variables out of the translated strings so shipment creation errors translate to the shop language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the error messages shown to the shop owner when a DPD shipment cannot be created. Driven by a support case where a merchant saw the raw DPD error
Unable to find user to authenticate!and could not tell it meant wrong API credentials.Covers three separate tickets:
Failed to create DPD shipment API status failed :). Reworded into a clear sentence.ApiErrorUtilityfor detection, with a unit test.l()translation key, so it never translated. Variables moved out viasprintfso messages now translate to the shop language.Release
Testing
tests/Unit/Util/ApiErrorUtilityTest.phpcovers authentication error detection (exact message, casing, unrelated errors, empty, null).Unable to find user to authenticate!.