Fix Shipment list sorting on joined-table columns#169
Merged
rokaszygmantas merged 2 commits intoMay 25, 2026
Merged
Conversation
Sorts on Tracking number, Receiver, Address, and City fell back to the main shipment table and produced no meaningful ordering. Added order_key entries pointing at the correct join aliases so PS uses the right columns in ORDER BY. filter_key is intentionally left unset so HAVING filters keep targeting the SELECT aliases. Also set default sort to id_dpd_shipment DESC so the latest shipments appear first.
rokaszygmantas
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
order_carrier,customer,address); previously PrestaShop fell back to the main shipment table and produced no useful ordering.id_dpd_shipment DESCso the latest shipments appear at the top.Implementation
order_key(notfilter_key) for the four joined-table columns using PrestaShop'salias!columnnotation.order_keyonly affects ORDER BY, leaving the existinghavingFilter(which targets theCONCAT/ aliased SELECT columns) untouched. Usingfilter_keywould have causedHAVING c.lastname LIKE ...and a 500 becausec.lastnameis not in the SELECT list._defaultOrderBy/_defaultOrderWay.Test plan
havingFilterstill works (receiver_name=John matches CONCAT alias)