Skip to content

fix: sanitize off-target NPC speech#90

Merged
JOY (JOY) merged 1 commit into
mainfrom
dev
May 18, 2026
Merged

fix: sanitize off-target NPC speech#90
JOY (JOY) merged 1 commit into
mainfrom
dev

Conversation

@JOY
Copy link
Copy Markdown
Contributor

Summary

  • sanitize model-selected say intents that reference a non-nearby target by clearing target_id
  • keep attack/interact target validation strict
  • add regression coverage so off-target speech remains model-backed instead of degrading to fallback

Local review

  • Local code-review fallback: approved, no blockers found in the scoped speech-sanitization diff
  • Boundary check: this only affects dialogue target metadata; game-state mutations remain server-validated and strict

Verification

  • npm run build (backend/nakama)
  • npm test (backend/nakama)
  • dotnet build Unity/SecondSpawn.AI.csproj --no-restore
  • dotnet build Unity/SecondSpawn.Networking.csproj --no-restore
  • git diff --check
  • docker restart second-spawn-nakama and /v2/rpc/secondspawn_health smoke

@JOY JOY (JOY) merged commit 81d6871 into main May 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant