pandas 3 support, flopy fixes and PRT demo fix + update#195
Merged
Conversation
…eplace deprecaded modelgrid.write_shapefile() call with GeoDataFrame.to_file()
* error with calculating t_years
* ci(test.yaml; build_docs.yaml): use 'modflow6' repo to get the latest release ('executables' repo is lagged and current Flopy was writting a COORDINATE_CHECK_METHOD input to the .prp file (for PRT) that was causing an error with MODFLOW 6.6.3)
* bump python version for build_docs.yaml to 3.14
* reference installation/environment.yml so that python version is only listed in one place * explicitly test with pandas 3 using another env file (Flopy requirements are apparently still resulting in pandas <3)
aleaf
force-pushed
the
main
branch
4 times, most recently
from
a4d4591 to
e48d2cb
Compare
Collaborator
|
@aleaf - it looks like maybe you didn't push the new ci/pandas3_env.yml file? I was working on pandas 3 support but kinda made things worse I think so I'll abandon my branch in favor of yours :). Thanks for working on this! |
Contributor
Author
|
ugh, sorry @mnfienen for the endless flails on the CI. I think it might be close. |
Collaborator
|
hey @aleaf - I'm just catching up from being away. Is this ready to merge? |
Contributor
Author
|
I think so. The scheduled tests that just ran on my fork just show the ci/pandas2_env.yml test run failing on ubuntu, due to an SSL error related to dataretrieval-python and NWIS. Since it's just happening on unbuntu, maybe it's related to how the certificate bundle is being set up on the ubuntu runners? |
…ct by pinning Flopy=3.9 for now. Flopy 3.10 wouldn't accept coordinate_check_method as an arg to the PRP package; for some reason installing MODFLOW from the modflow6 repo didn't result in version 6.7 for the PRT run in notebook 10a, even though the reported MODFLOW version in the path was 6.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unpinrepin Flopy version at 3.9 to resolve conflict between Flopy 3.10 and MODFLOW < 6.7 (for unknown reasons was still getting MODFLOW 6.6.3 for PRT run in notebook 10a, even after installing 6.7)...