Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
36f1d7b
add new event consument and new email template
amdomanska Jan 5, 2026
dd88976
create a notification, remove obsolete email code
amdomanska Jan 5, 2026
8c5d266
trigger the event
amdomanska Jan 5, 2026
70c82de
add unit tests and fix errors
amdomanska Jan 5, 2026
dc0f912
make sure event is triggered correctly
amdomanska Jan 5, 2026
c6b0c63
add FlagReminderConsumer
amdomanska Jan 5, 2026
d9b5e25
add flag reminder unittests
amdomanska Jan 5, 2026
e51cd4b
add unit test
amdomanska Jan 5, 2026
dd6c6a8
add script to test bg job + notifications
amdomanska Jan 5, 2026
660caa3
add a script button to the testdrive page; modify flags notifications…
amdomanska Jan 6, 2026
916d87d
add functional tests
amdomanska Jan 6, 2026
1a4e87e
fix error in the functional test
amdomanska Jan 6, 2026
b1b6a07
fix error in the functional test
amdomanska Jan 6, 2026
35e4c4f
fix setup in functional test
amdomanska Jan 6, 2026
fbb397d
fix setup in functional test
amdomanska Jan 6, 2026
7eefd32
add deadline validation - validate if not empty if not disabled, vali…
amdomanska Dec 16, 2025
d6aebf6
validate deadline for any value
amdomanska Dec 16, 2025
6774ce0
add assignee validation
amdomanska Dec 16, 2025
6b5df64
remove info message
amdomanska Dec 16, 2025
11cdad6
add functional tests
amdomanska Dec 16, 2025
271bf75
partial updates for flag deadline/assignee validation. Mostly workin…
richard-jones Feb 13, 2026
2ee88d2
fix validator for silent failures
richard-jones Feb 17, 2026
de76d4b
this implements a conditional validator on the resolved flags, so the…
richard-jones Feb 20, 2026
721a447
merge up from develop
richard-jones Feb 20, 2026
1132f9c
some refactoring to bring the flag reminder into the tasks, a bunch o…
richard-jones Feb 23, 2026
ef9234f
normalise validation in the back end with validation in the front end
richard-jones Feb 24, 2026
d55be22
Merge branch 'develop' into feature/4202_flags_clean
richard-jones Feb 24, 2026
2597115
Merge branch 'feature/4203_flags_notifications' into feature/4202-420…
Steven-Eardley Mar 12, 2026
23ea54f
Merge branch 'feature/4202_flags_clean' into feature/4202-4203_flags_…
Steven-Eardley Mar 12, 2026
ff3ede0
Merge branch 'develop' into feature/4202_flags_clean
amdomanska Mar 26, 2026
6360223
Merge branch 'develop' into feature/4202-4203_flags_combined
amdomanska Mar 26, 2026
ab48c13
error in the testdrive
amdomanska Mar 26, 2026
682c824
fix journal form not being saved
amdomanska Mar 26, 2026
e240b26
fix functional test
amdomanska Mar 26, 2026
fff16f0
fix functional test
amdomanska Mar 26, 2026
3eceec0
Apply suggestions from code review
Steven-Eardley Mar 31, 2026
c009f48
Merge branch 'develop' into feature/4202_flags_clean
Steven-Eardley Mar 31, 2026
6403a59
Merge branch 'develop' into feature/4202-4203_flags_combined
Steven-Eardley Mar 31, 2026
dc5d0e7
Merge branch 'feature/4202_flags_clean' into feature/4202-4203_flags_…
Steven-Eardley Mar 31, 2026
fdee934
add teardown script
amdomanska Mar 31, 2026
89f0285
remove second form flag from the application_forms definitions
amdomanska Mar 31, 2026
1af720e
update flags templates
amdomanska Mar 31, 2026
d3f4261
hide fields if no flag
amdomanska Mar 31, 2026
810abca
add btn and cancel flag functionality
amdomanska Mar 31, 2026
a086b13
update the crosswalk to handle single flag form
amdomanska Apr 2, 2026
2926cfc
create flags header
amdomanska Apr 2, 2026
c2f032d
resolve flag-ui
amdomanska Apr 2, 2026
36990b9
Merge branch 'develop' into feature/4202-4203_flags_combined
amdomanska Apr 13, 2026
06d91b0
toggle buttons correctly on resolve and add
amdomanska Apr 13, 2026
e717141
ensure flags header behaves properly when resolving
amdomanska Apr 13, 2026
fea2e21
fix crosswalk to accept only 1 flag, non-repeatable, and the new reso…
amdomanska Apr 13, 2026
63a5506
fix the created info in the flags header
amdomanska Apr 13, 2026
5c22dbc
fix the validator
amdomanska Apr 13, 2026
ed44349
do not clear resolved input on cancel
amdomanska Apr 13, 2026
5dabdea
remove obsolete code, fix author display
amdomanska Apr 13, 2026
bf09c97
fix and improve func tests
amdomanska Apr 14, 2026
21e5c7a
remove obsolete print)
amdomanska Apr 14, 2026
90fde9d
fix the error in a yml
amdomanska May 14, 2026
e3d90d7
Merge branch 'develop' into feature/4202-4203_flags_combined
amdomanska May 14, 2026
11a3b02
fix errors in the functional tests
amdomanska May 27, 2026
741f6a5
add explanation to marked as resolved
amdomanska May 27, 2026
3985faf
make note required when not disabled
amdomanska May 27, 2026
a04cae4
fields are disabled on resolve; changes to functional script
amdomanska May 27, 2026
bc10e53
make errors list more useful
amdomanska May 27, 2026
5ce63ad
some changes to functional tests
amdomanska May 27, 2026
4a24bb8
remove unnecessary setup
amdomanska May 27, 2026
4fff5f8
small yml fix
amdomanska May 27, 2026
55bdb93
Merge branch 'develop' into feature/4202-4203_flags_combined
amdomanska May 29, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions cms/data/notifications.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,30 @@ bg:job:admin_reports:export_available:
short:
Report "{name}" ready for download

bg:job:approaching_flag_deadline:notify:
long: |
"The deadline for the flag in "{journal_title}" (id: {id}) is in 7 days."
short:
Deadline reminder

flag:assigned:notify:
long: |
"A new flag in "{journal_title}" (id: {id}) has been assigned to you"
short:
New flag

journal:assed:assigned:notify:
long: |
The journal **{journal_name}** has been assigned to you by the Editor of your group **{group_name}**. Please start work on this within 10 days.
short:
New journal ({issns}) assigned to you

journal:maned:discontinuing_soon:notify:
long: |
Journal "{title}" (id: {id}) will discontinue in {days} days.
short:
Journal discontinuing

journal:editor_group:assigned:notify:
long: |
The journal **{journal_name}** has been assigned to your group by a Managing Editor. Please assign this to an Associate Editor within 5 working days.
Expand Down Expand Up @@ -186,9 +204,3 @@ update_request:publisher:submitted:notify:
**This is an automated message.**
short:
Your update request ({issns}) has been submitted

journal:maned:discontinuing_soon:notify:
long: |
Journal "{title}" (id: {id}) will discontinue in {days} days.
short:
Journal discontinuing
126 changes: 77 additions & 49 deletions cms/sass/layout/_editorial-panel.scss
Original file line number Diff line number Diff line change
@@ -1,45 +1,80 @@
.editorial-panel {
margin-top: 0;
.spanPretendingToBeInput {
display: block;

fieldset {
padding: 0 !important;
}
&:has(svg) {
display: flex;
align-items: flex-start;
gap: .5rem;
}

background-color: $disabled;
width: 100%;
padding: 0.5rem;
margin-bottom: .375rem;
font-style: italic;

span {
white-space: normal;
}
}

margin-top: 0;

fieldset {
padding: 0 !important;
}

.form__question {
margin: 0 !important;

.form__question {
margin: 0 !important;
select, textarea, input {
width: 100%;
select, textarea, input {
width: 100%;
}
}
}

hr {
margin: $spacing-02;
}
hr {
margin: $spacing-02;
}

@media (min-width: 992px) {
position: -webkit-sticky;
position: sticky;
top: 100px;
@media (min-width: 992px) {
position: -webkit-sticky;
position: sticky;
top: 100px;

&__wrapper {
display: flex;
flex-direction: column;
max-height: calc(100vh - 75px - 1.5rem - 25px); //(full viewport)-(nav height)-(top padding)-(bottom padding)
display: flex;
flex-direction: column;
max-height: calc(100vh - 75px - 1.5rem - 25px); //(full viewport)-(nav height)-(top padding)-(bottom padding)
}

&__content {
flex: 1;
overflow-y: scroll;
flex: 1;
overflow-y: scroll;

select, textarea, input {
display: block;
}
select, textarea, input {
display: block;
}
}
}
}

.flag--resolved {
position: relative;
opacity: 0.2; /* Set opacity of entire div */
.pretendInputWrapper {
.pretendLabel {
margin-bottom: .75rem;
font-size: 1.125em;
}
.pretendInput {
margin-bottom: .375rem;
width: 100% !important;
border: 1px solid #A9A7A5;
padding: .5em;
font-size: 1em;
}
}

}

.flag--resolved::before {
Expand All @@ -56,77 +91,70 @@
letter-spacing: 0.2em; /* Adjust the spacing between letters for the stamp */
font-weight: bold;
}

.editorial-panel__content {
.form__question.editorial-panel__question {
padding: 0 !important;

.editorial-panel__question-header {
padding: .5rem;
align-items: flex-start;

label, p {
margin: 0;
}
}

.editorial-panel__legend {
display: flex;
align-items: center;
gap: .5rem;
padding: 0 .5rem;
margin-bottom: .375rem;
display: flex;
align-items: center;
gap: .5rem;
padding: 0 .5rem;
margin-bottom: .375rem;
}

.editorial-panel__questions-content {
.form-inputs--container {
&:has(input[type="hidden"]) {

}

&:has(label) {
label {
font-size: .75rem;
margin-bottom: 0;
margin-left: .5rem;

.form__question--optional {
font-size: .75rem;
}
}
}

&:has(svg) {
position: relative;
width:100%;
width: 100%;

svg {
position: absolute;
left: .5rem;
bottom: 22px;
z-index: 1;
}

.select2-choice {
.select2-chosen {
padding-left: calc(.5rem + 20px);
}
}
}

input {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}

span.spanPretendingToBeInput {
display: block;
&:has(svg) {
display: flex;
align-items: flex-start;
gap: .5rem;
}
background-color: $disabled;
width: 100%;
padding: 0.5rem;
margin-bottom: .375rem;
font-style: italic;

span {
white-space: normal;
}
}

input:disabled ~ label {
display: none;
}
Expand Down
3 changes: 2 additions & 1 deletion dev.template.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ HUEY_SCHEDULE = {
"datalog_journal_added_update": CRON_NEVER,
"auto_assign_editor_group_data": CRON_NEVER,
"ris_export": CRON_NEVER,
"site_statistics": CRON_NEVER
"site_statistics": CRON_NEVER,
"approaching_flag_deadline": CRON_NEVER
}

###########################################
Expand Down
Loading
Loading