test(e2e): cover MCP endpoint and overridden signal tools#302
Merged
Conversation
Adds the first e2e coverage for the /mcp path, automating the manual smoke test run against prod v0.4.12: - tools/list exposes the overridden shortcut tools with required ToolOnly args (signalRequests / signalNames) - telemetry_get_latest_signals and telemetry_get_signals_time_series return seeded ClickHouse data through the full chain: JSON-RPC -> selection template render -> gqlgen executor with shared extensions -> privilege directives -> ClickHouse - a signalRequests entry missing 'agg' fails template rendering with a clear error before the executor runs - missing or privilege-less JWTs surface as GraphQL unauthorized errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First e2e coverage for the
/mcppath — automates the manual smoke test that verified prod v0.4.12 after #300.TestMCPToolsList— builtin tools present; the two overridden shortcut tools require their ToolOnly args (signalRequests/signalNames).TestMCPSignalTools— seeds speed + SoC signals in ClickHouse, then over raw stateless JSON-RPC:telemetry_get_latest_signalsreturns the seeded latest valuestelemetry_get_signals_time_seriesreturns correctMAX/LASTaggregation bucketssignalRequestsentry missingaggfails template rendering with a clear tool error (server-garagemissingkey=error), executor never runsunauthorizederrorsExercises the full chain added in #300: JSON-RPC → selection template render → gqlgen executor with shared extensions → privilege directives → ClickHouse.
Testing
Full
go test ./...(incl. all existing e2e) + lint pass.🤖 Generated with Claude Code