fix(mcp): apply shared gqlgen extensions to MCP executor#84
Merged
Conversation
The MCP path used a bare executor, bypassing the extensions registered on the HTTP GraphQL server: complexity limit, introspection, metrics tracer, and the error presenter. configureGQLExtensions now holds the single shared list and is applied to both *handler.Server and *executor.Executor via server-garage v0.4.0's ExecutorOption hook. Bumps server-garage v0.1.1 -> v0.4.0.
Unpinned 'latest' pulls v2.12.2, whose release artifact fails the installer's sha256 verification, breaking CI. Matches the pin in telemetry-api and server-garage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Same gap fixed in DIMO-Network/telemetry-api#300: the MCP handler used a bare gqlgen executor, so everything registered on the HTTP GraphQL server via
srv.Usewas bypassed on MCP tool calls —FixedComplexityLimit(100), introspection, the metrics tracer, and the error presenter.Fix
configureGQLExtensionsholds the single shared extension list, applied to both*handler.Serverand the MCP*executor.Executorvia server-garage v0.4.0'sExecutorOptionhook.Testing
Full
go test ./...+ lint pass.🤖 Generated with Claude Code