intg-1866 dtc error codes implementation on vehicle start#121
Merged
Conversation
| return errors.Wrap(err, fmt.Sprintf("failed to scan for dtc. fail count since boot: %d", ls.failureCount)) | ||
| } | ||
| if len(codes) > 0 { | ||
| // send the dtc in the signals using status topic. Seems pointless to send any other common data |
Contributor
There was a problem hiding this comment.
Yes, agree, we probably can at some point of time even get rid of common data, since it is has only a timestamp
Contributor
|
After upgrading to golangci-lint v2, numerous linter errors arise that were not detected using linter v1. So, I decided to skip fixing it, since it takes too much effort; at this point, it is not a priority. Ticket created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run DTC error cods command on vehicle start, same flow as we do for fingerprint.
This just re-uses the signals data on the device status topic. This does not set some of the common data or the vehicle make model year as it seems useless for this feature. Will need to double check this isn't a problem for ingest.
Signal name that will be mapped is
dtcErrorsand the value can be comma delimited - which we'll need to handle for telemetry ingest.