Bump model-garage to v1.0.12#280
Merged
Merged
Conversation
Pulls in the Ruptela VIN leading-space trim fix so payloads where PID 104 is left-padded with 0x20 bytes now produce a valid fingerprint instead of being silently dropped. https://claude.ai/code/session_01N6jjMS5NG9iRVCyKfSnHws
The 'latest' tag currently resolves to v2.12.2, whose published tarball has a different SHA256 than the one baked into the upstream install script, so make tools fails the checksum verification. https://claude.ai/code/session_01N6jjMS5NG9iRVCyKfSnHws
Switch from raw.githubusercontent.com/.../master/install.sh to the canonical https://golangci-lint.run/install.sh that golangci-lint recommends, which resolves the stale checksums in the master-branch script. With the recommended installer the version pin is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/DIMO-Network/model-garagefrom v1.0.11 → v1.0.12.DecodeFingerprintnow trims leading padding (not just trailing), so PID 104 hex like2020202020...no longer leaves leading-space bytes that failvin.IsValidVIN()/vin.IsValidJapanChassis()and cause the fingerprint to be silently dropped ininternal/processors/fingerprintvalidate.Test plan
go build ./...go test ./internal/processors/fingerprintvalidate/...model-garage'sconvert_fingerprint_test.go(added in Bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4 #261).https://claude.ai/code/session_01N6jjMS5NG9iRVCyKfSnHws
Generated by Claude Code