Improve Birth Wheel response state#886
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_1edd4a85-aa92-4631-a108-aa0bc3cd1af1) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac81927426
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| normalized === 'now' | ||
| || normalized === 'today' | ||
| || SAME_DAY_PART_PATTERN.test(normalized) | ||
| ) { |
There was a problem hiding this comment.
When a captured phrase combines another date with a day part, this branch treats the whole phrase as same-day before extracting the explicit date. For example, parseLooseDateToken('tomorrow evening', new Date('2026-06-04T12:00:00Z')) now returns 2026-06-04, and ranged phrases like starting tomorrow morning build a window from today instead of June 5. That sends future timing reads to the current day's geometry whenever users add morning/evening/afternoon to a non-today date.
Useful? React with 👍 / 👎.
| /\bhigh[\s-]?valence\s+date\b/i, | ||
| /\bwhen\s+is\s+my\s+next\s+(?:high[\s-]?valence|positive\s+bias)\b/i, | ||
| /\bwhen\s+(?:is|does)\s+(?:the\s+)?(?:next|best)\s+(?:high[\s-]?valence|positive\s+bias|expansion)\b/i, | ||
| /\b(?:tell\s+me\s+about|read|show|check|pull|fetch|run)\b[\s.?!,;:…-]{0,20}\b(?:tonight|(?:this\s+)?(?:evening|morning|afternoon))\b/i, |
There was a problem hiding this comment.
Because this new timing-window regex is not anchored to the start of the utterance or another request context, any sentence containing verbs like read, run, or check near tonight is classified as NEW_SYMBOLIC_READ before follow-up handling runs. For example, classifySymbolicMomentTurn('I need to check tonight before deciding') now triggers a fresh symbolic read, so ordinary testimony/decision chat can be promoted into the exact new-read path this change is trying to avoid.
Useful? React with 👍 / 👎.
|
1 participant
Raven could receive a question from the Birth Wheel page while the wheel itself stayed visually quiet, which made the response feel stalled even though the summary and scope panes were waiting on the read. Short time-bound prompts like
tell me about...tonight.could also stay in CHAT because date parsing alone did not trip the timing-window intent gate.This PR adds an in-flight Birth Wheel affordance: the Reading tab glows while Raven is responding, and a compact animated Read glyph appears over the wheel without obscuring the natal chart. It also routes casual same-day time windows (
tonight,this evening,this morning,this afternoon) into the symbolic timing path and keeps ordinary testimony/decision follow-ups from being promoted into fresh reads.Validation:
npm run typechecknpm run buildnode --import tsx --test src/lib/raven/__tests__/symbolicMomentIntent.test.tsNote: strict Sherlog preflight is blocked by baseline vault/profile and runtime contract telemetry unrelated to this diff: 3 vault profiles are missing
natalChartblobs, andvoice_drift_collapse_surfaceis already present in runtime collapse evidence. The branch was pushed with--no-verifyafter user approval.Note
Medium Risk
Intent and date-regex changes affect raven-chat routing for many user phrasings; misclassification could trigger or skip sky reads. UI changes are localized to guided wheel/reading state.
Overview
Adds visible in-flight read feedback on the Birth Wheel guided view so a wheel question no longer looks idle while Raven is still responding: the Reading tab stays highlighted (with a pulse while loading) and a compact Read glyph overlays the wheel on desktop, mobile overlay, and active map panes.
Extends natural-language date parsing and timing-window / symbolic-read intent so casual same-day phrases (
tonight,this evening,this morning,this afternoon, including punctuation liketell me about...tonight.) resolve to today’s single-day range and can enter the symbolic timing path, while non-read follow-ups (e.g. exhausted tonight) stay out of timing-window scans. Tests cover the new date ranges and intent boundaries.Reviewed by Cursor Bugbot for commit ac81927. Bugbot is set up for automated code reviews on this repo. Configure here.