Fix Vault Relationship Mapping vs Synastry Drift#882
Fix Vault Relationship Mapping vs Synastry Drift#882google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
Pull request overview
This PR renames the user-facing relationship read product from “Synastry Mirror Report” to “Relationship Mirror Report” (and “Full Relationship Mirror”) across Raven prompt law, taxonomy, and capability grounding to reduce confusion with classical synastry unless explicitly requested. It also includes a couple of small TypeScript fixes uncovered during typechecking.
Changes:
- Updated canonical product titles in
mirrorArtifactKinds.tsand propagated the new labels through prompt law/taxonomy blocks and degraded fallback copy. - Updated relational lane guidance to reflect “relationship mapping” terminology in contrast-mode framing and RELATIONAL_MAPPING lane kernel.
- Updated unit + smoke tests and fixed minor TS issues in two UI panels.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vessel/src/test/api-smoke.test.ts | Updates smoke assertion to expect the new capability/product line wording. |
| vessel/src/lib/raven/relationalIntent.ts | Renames contrast-mode framing language away from “synastry” to “relationship mapping.” |
| vessel/src/lib/raven/prompts/blocks/mirror_product_taxonomy.md | Updates product taxonomy table to the new relationship product names. |
| vessel/src/lib/raven/persona-law.ts | Updates persona law and RELATIONAL_MAPPING lane kernel to use the new product labels. |
| vessel/src/lib/raven/mirrorProductPrompt.ts | Updates lane guidance and capability grounding line to “Relationship Mirror Report / Full Relationship Mirror.” |
| vessel/src/lib/raven/mirrorArtifactKinds.ts | Changes the user-facing family/full-read titles for the synastry_mirror family to the new relationship names. |
| vessel/src/lib/raven/degradedReplyBuilders.ts | Updates user-facing degraded fallback strings to reference the renamed product. |
| vessel/src/lib/raven/tests/mirrorProductPrompt.test.ts | Adjusts prompt taxonomy tests to assert the new relationship product naming. |
| vessel/src/lib/raven/tests/mirrorArtifactKinds.test.ts | Updates artifact kind title expectations to the new relationship product naming. |
| vessel/src/components/raven/poetic-codex/PoeticIndexCardPanel.tsx | Fixes type issues by importing ChatMessage and adjusting transit driver extraction. |
| vessel/src/components/ConstellationVaultPanel.tsx | Fixes a property typo (promptQuestion) for sealed keepsake subline rendering. |
| vessel/src/app/api/raven-chat/promptLines.ts | Updates capability grounding lines used in prompt assembly to the new relationship product naming. |
| const drivers = targetMessage.corridorSnapshot?.transitDrivers?.subjectA?.drivers?.map((d: any) => d) || []; | ||
| const geometryHash = targetMessage.corridorSnapshot?.transitDrivers?.subjectA?.drivers?.[0] | ||
| ? `geo_${targetMessage.id.slice(0, 6)}` | ||
| : `geo_session_${targetMessage.id.slice(0, 4)}`; |
I've refactored the product names for relationship queries from "Synastry Mirror Report" to "Relationship Mirror Report" (and "Full Relationship Mirror" for the second pass) to prevent confusing the lane with traditional classical synastry unless explicitly requested.
This involved updating:
mirrorArtifactKinds.tsto redefineMIRROR_REPORT_FAMILY_TITLEandMIRROR_FULL_READ_LABEL_TITLE.mirrorProductPrompt.ts,persona-law.ts, anddegradedReplyBuilders.tsto instruct the Raven LLM to use the new names for relationships.mirror_product_taxonomy.mdandpromptLines.ts.relationalIntent.ts.Also fixed a couple of TypeScript errors in
ConstellationVaultPanel.tsxandPoeticIndexCardPanel.tsxthat were revealed during thenpm run typecheckverification run.I ran the tests and preflight checks, and they passed.
PR created automatically by Jules for task 14029243858109309865 started by @DHCross