fix(dashboard): remove dead log-tracing feature#1158
Merged
Conversation
The log-tracing screens call gs/debug/logs, which was removed from the API together with the App Insights integration. Both screens 404 with no data source to rebuild onto, so remove the feature: the hook, the three screens, the trace time-chart component, their routes, and the dashboard/sitemap navigation entries.
Collaborator
Author
|
Review summary Reviewed the removal for completeness and safety, plus an adversarial pass hunting for anything left dangling:
Verdict: go — no blocking findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The log-tracing dashboard screens post to
gs/debug/logs, which no longer exists in the API — it was removed together with the App Insights integration (DFXswiss/api#3994). BothgetRealunitTracesandgetAllTracestherefore hit a non-existent route and return 404, so/dashboard/log-tracing/alland/dashboard/log-tracing/realunitare non-functional. Since #1146 switched the hook to the guarded API, a 404 carries noTFA_REQUIREDcode, so the 2FA redirect can't recover it either.The backing data source (App Insights) was retired, so there is nothing to rebuild the hook onto —
gs/debugis a structured DB-query endpoint, not a log/trace store. Hence: remove the dead feature.Change
Remove the log-tracing dashboard area in full:
src/hooks/log-tracing.hook.ts, the three screens (dashboard-log-tracing,dashboard-log-tracing-realunit,dashboard-log-tracing-all), and thelog-trace-time-chartcomponent.App.tsx(lazy imports + thelog-tracingroute subtree),dashboard.screen.tsx(the Log Tracing card), andsitemap.screen.tsx(three entries).The sibling
financialdashboard routes/cards are untouched. Net: 918 lines removed, no code added.Verification
npm run lint— cleannpm run test— 28 suites / 306 tests passnpm run build:dev— compiles (type-check via fork-ts-checker), no dangling referencesRelated