Skip to content

fix(dashboard): remove dead log-tracing feature#1158

Merged
TaprootFreak merged 1 commit into
developfrom
fix/remove-log-tracing-dashboard
Jul 2, 2026
Merged

fix(dashboard): remove dead log-tracing feature#1158
TaprootFreak merged 1 commit into
developfrom
fix/remove-log-tracing-dashboard

Conversation

@TaprootFreak

Copy link
Copy Markdown
Collaborator

Problem

The log-tracing dashboard screens post to gs/debug/logs, which no longer exists in the API — it was removed together with the App Insights integration (DFXswiss/api#3994). Both getRealunitTraces and getAllTraces therefore hit a non-existent route and return 404, so /dashboard/log-tracing/all and /dashboard/log-tracing/realunit are non-functional. Since #1146 switched the hook to the guarded API, a 404 carries no TFA_REQUIRED code, so the 2FA redirect can't recover it either.

The backing data source (App Insights) was retired, so there is nothing to rebuild the hook onto — gs/debug is a structured DB-query endpoint, not a log/trace store. Hence: remove the dead feature.

Change

Remove the log-tracing dashboard area in full:

  • Deleted src/hooks/log-tracing.hook.ts, the three screens (dashboard-log-tracing, dashboard-log-tracing-realunit, dashboard-log-tracing-all), and the log-trace-time-chart component.
  • Stripped references in App.tsx (lazy imports + the log-tracing route subtree), dashboard.screen.tsx (the Log Tracing card), and sitemap.screen.tsx (three entries).

The sibling financial dashboard routes/cards are untouched. Net: 918 lines removed, no code added.

Verification

  • npm run lint — clean
  • npm run test — 28 suites / 306 tests pass
  • npm run build:dev — compiles (type-check via fork-ts-checker), no dangling references
  • Repo-wide grep for every log-tracing symbol/path returns zero hits

Related

The log-tracing screens call gs/debug/logs, which was removed from the API
together with the App Insights integration. Both screens 404 with no data
source to rebuild onto, so remove the feature: the hook, the three screens,
the trace time-chart component, their routes, and the dashboard/sitemap
navigation entries.
@TaprootFreak

Copy link
Copy Markdown
Collaborator Author

Review summary

Reviewed the removal for completeness and safety, plus an adversarial pass hunting for anything left dangling:

  • Completeness / consistency — every deleted module's references are gone too: the lazy imports and the whole log-tracing route subtree in App.tsx, the dashboard card, and the three sitemap entries. The sibling financial routes/cards are untouched and the route tree stays syntactically valid. No orphaned imports or dead code left behind.
  • Dangling references — repo-wide grep for every log-tracing symbol/path (useLogTracing, ParsedTrace, GenericTrace, LogQueryResult, parseTrace, parseGenericTrace, log-trace-time-chart, /dashboard/log-tracing, …) returns zero hits.
  • Gatesnpm run lint clean, npm run test 28 suites / 306 tests pass, npm run build:dev compiles with no dangling references (the type-check runs there via fork-ts-checker).
  • Rebased onto the current develop (incl. Fix RealUnit dashboard 404s from double-slash API URLs #1151, Bump @dfx.swiss/react to 1.4.1 for hardened URL joining #1155, Restrict RealUnit price chart to API-supported timeframes #1156) and re-ran the gates green.

Verdict: go — no blocking findings.

@TaprootFreak TaprootFreak marked this pull request as ready for review July 2, 2026 22:13
@TaprootFreak TaprootFreak requested a review from davidleomay as a code owner July 2, 2026 22:13
@TaprootFreak TaprootFreak merged commit b14f4e3 into develop Jul 2, 2026
6 checks passed
@TaprootFreak TaprootFreak deleted the fix/remove-log-tracing-dashboard branch July 2, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log-tracing dashboard screens call removed gs/debug/logs endpoint → 404

1 participant