Skip to content

fix(docker): run node under tini instead of npm to silence shutdown noise #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Danswar wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −1
Open

fix(docker): run node under tini instead of npm to silence shutdown noise #4222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ RUN echo "$GIT_COMMIT" > dist/version.txt

FROM node:20-alpine

# tini as PID 1: forwards SIGTERM to node so stops behave exactly as they did
# under npm (immediate exit), without npm's 5-line error block on every stop.
# Bare node as PID 1 would IGNORE SIGTERM (no handler + PID-1 semantics) and
# get SIGKILLed after the grace period instead.
RUN apk add --no-cache tini

USER node
WORKDIR /home/node

Expand All @@ -45,4 +51,6 @@ COPY --from=builder /home/node/assets ./assets

EXPOSE 3000

CMD ["npm", "run", "start:prod"]
ENTRYPOINT ["/sbin/tini", "--"]
# Mirrors package.json start:prod — keep the two in sync.
CMD ["node", "--max-old-space-size=6144", "dist/src/main"]