Skip to content
This repository was archived by the owner on Nov 16, 2022. It is now read-only.

Feature/archive#87

Open
DEcSENT wants to merge 22 commits into
masterfrom
feature/archive
Open

Feature/archive#87
DEcSENT wants to merge 22 commits into
masterfrom
feature/archive

Conversation

@DEcSENT
Copy link
Copy Markdown
Owner

@DEcSENT DEcSENT commented Jan 7, 2021

New Archive screen.
New base Notepad and Archive modules.

@DEcSENT DEcSENT added the WIP Work in progress label Jan 7, 2021
@DEcSENT DEcSENT self-assigned this Jan 7, 2021
@Miranda-Bot
Copy link
Copy Markdown

2 Warnings
⚠️ Big PR
⚠️ app/src/main/res/layout/activity_main.xml#L7 - Possible overdraw: Root element paints background @color/screenBackgroundColor with a theme that also paints a background (inferred theme is @style/AppTheme)

Generated by 🚫 Danger

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 7, 2021

Codecov Report

Merging #87 (04d759e) into master (cb4346b) will increase coverage by 5.51%.
The diff coverage is 23.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     44.09%   49.60%   +5.51%     
+ Complexity       44       37       -7     
============================================
  Files            34       31       -3     
  Lines           322      256      -66     
  Branches         26       14      -12     
============================================
- Hits            142      127      -15     
+ Misses          172      122      -50     
+ Partials          8        7       -1     
Impacted Files Coverage Δ Complexity Δ
...e/data/repository/archive/ArchiveDataRepository.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...c/archive/domain/usecase/archive/ArchiveUseCase.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/com/dvinc/archive/ui/archive/ArchiveFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/com/dvinc/archive/ui/archive/ArchiveViewModel.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/com/dvinc/archive/ui/archive/ArchiveViewState.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/kotlin/com/dvinc/notepad/ui/note/NoteFragment.kt 0.00% <ø> (ø) 0.00 <0.00> (?)
.../kotlin/com/dvinc/notepad/ui/note/NoteViewState.kt 75.00% <ø> (ø) 0.00 <0.00> (?)
...in/com/dvinc/notepad/ui/notepad/NotepadFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/com/dvinc/notepad/ui/notepad/NotepadViewState.kt 100.00% <ø> (ø) 2.00 <0.00> (?)
...n/com/dvinc/notepad/ui/notepad/NotepadViewModel.kt 63.63% <12.50%> (ø) 5.00 <1.00> (?)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffd25d...04d759e. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants