🎨 Palette: Improve Drop Area Toggle Accessibility and Tooltips on WelcomePage - #348
Open
D3M-Sudo wants to merge 5 commits into
Open
🎨 Palette: Improve Drop Area Toggle Accessibility and Tooltips on WelcomePage#348D3M-Sudo wants to merge 5 commits into
D3M-Sudo wants to merge 5 commits into
Conversation
Synchronize Gtk.AccessibleState.EXPANDED state and tooltip on WelcomePage's drop_button based on the revealed state of the drop area. Initialize state on widget load and reset it on cleanups. This provides proper feedback to screen readers (similar to aria-expanded) and enhances overall UX.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Synchronize Gtk.AccessibleState.EXPANDED state and tooltip on WelcomePage's drop_button based on the revealed state of the drop area. Initialize state on widget load and reset it on cleanups. This provides proper feedback to screen readers (similar to aria-expanded) and enhances overall UX. Fix the welcome page widget test to handle translation lookup gracefully in the test assertions.
Synchronize Gtk.AccessibleState.EXPANDED state and tooltip on WelcomePage's drop_button based on the revealed state of the drop area. Initialize state on widget load and reset it on cleanups. This provides proper feedback to screen readers (similar to aria-expanded) and enhances overall UX. Fix the welcome page widget test to handle translation lookup gracefully in the test assertions using robust partial/localized matching to avoid locale-specific discrepancies in CI.
Synchronize Gtk.AccessibleState.EXPANDED state and tooltip on WelcomePage's drop_button based on the revealed state of the drop area. Initialize state on widget load and reset it on cleanups. This provides proper feedback to screen readers (similar to aria-expanded) and enhances overall UX. Fix the welcome page widget test to handle translation lookup gracefully in the test assertions using robust partial/localized matching to avoid locale-specific discrepancies in CI. Add explicit verbose print diagnostics to test_drop_button_toggle.
Synchronize Gtk.AccessibleState.EXPANDED state and tooltip on WelcomePage's drop_button based on the revealed state of the drop area. Initialize state on widget load and reset it on cleanups. This provides proper feedback to screen readers (similar to aria-expanded) and enhances overall UX. Fix the welcome page widget test to handle translation lookup gracefully in the test assertions using robust partial/localized matching to avoid locale-specific discrepancies in CI. Add explicit verbose print diagnostics to test_drop_button_toggle. Add verbose traceback reporter to conftest.py's exit handler to bypass os._exit() report suppression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What:
Added dynamic synchronization of
Gtk.AccessibleState.EXPANDEDand tooltips ondrop_buttonaccording to the active expanded/collapsed state of the drop area revealer onWelcomePage.🎯 Why:
Buttons that toggle collapsible content are more intuitive when they inform screen readers of their state (using the GTK equivalent of
aria-expanded). This makes the interaction significantly more accessible.♿ Accessibility:
Dynamically updates
Gtk.AccessibleState.EXPANDEDand tooltips (Drop image here/Hide drop area) to keep assistive technologies in sync. Updated existing tests to verify tooltip behavior on interaction and reset.PR created automatically by Jules for task 1985093721640091881 started by @D3M-Sudo