Normalize deployment and operations#2
Merged
Conversation
CyrusAuyeung
marked this pull request as ready for review
July 16, 2026 10:55
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c336f1eca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize the public Blindot API deployment repository around an explicit configuration-v2 contract, safer single-host defaults, a hardened and testable SMTP-to-Brevo relay, repeatable validation, and operations-focused documentation.
What changed
smtp2brevowith bounded inputs and timeouts, TLS 1.2+, constant-time credential checks, attachment rejection, privacy-safe structured logs, graceful shutdown, a TLS health check, locked dependencies, and seven unit tests.Why
The repository is the public deployment and operations layer, not the Sub2API core source. Its prior configuration mixed Compose interpolation with application settings that were not consistently injected, retained production-sized tuning values that were unsafe to activate blindly, encoded deployment-specific network details, and lacked a migration guard or automated validation. Configuration v2 makes that boundary explicit and prevents an existing private environment from being applied without review.
Impact and migration
docs/migration-v2.mdand explicitly setBLINDOT_DEPLOY_CONFIG_VERSION=2before manually promoting these files.weishaw/sub2api:0.1.113.Validation
npm ci --ignore-scriptsnpm run checknpm test— 7/7 passednpm audit --omit=dev— 0 vulnerabilitiesnpm ls --allandnpm outdatedgit diff --checksh -nfor both scriptssh scripts/check-public-safe.sh, including full Git-history checks/healthreturned 200 and unauthenticated/v1/modelsreturned 401Checklist
sh scripts/check-public-safe.shpassesNotes
Pull requests and merges in this repository do not deploy production. Promotion remains an explicit operator action.