Skip to content

chore: bump action runtime to node24#115

Merged
ronens88 merged 1 commit into
mainfrom
chore/node24-bump
May 10, 2026
Merged

chore: bump action runtime to node24#115
ronens88 merged 1 commit into
mainfrom
chore/node24-bump

Conversation

@ronens88
Copy link
Copy Markdown
Contributor

@ronens88 ronens88 commented May 8, 2026

Summary

  • Both action.yml files declared using: node20. GitHub is forcing Node 24 on hosted runners on June 2, 2026 and removing Node 20 support on September 16, 2026 — without this bump, the action breaks on that date.
  • Two-line change: node20node24 in the root action.yml and attest/action.yml. No source/dist rebuild needed (action runtime is declared independently of the bundled JS).

Risk

  • Self-hosted runners must be on a version of actions/runner that ships Node 24. Customers on older runners will fail with "Node 24 not found." Same constraint applies to GHES.
  • The bundled dist/*.js is ncc-transpiled; runtime-compatible with Node 24. The existing scripts/fix-esm-require.js shim (added in 1bec56a for Node 20+ ESM/require interop) remains effective.
  • Plan to backport the same change to v0.10.x as v0.10.1 so customers pinned to @v0 are not stranded.

Test plan

  • verify-pr workflow passes on this PR
  • Manually trigger or observe a downstream consumer using @chore/node24-bump (or wait for first run on a Node 24 runner post-merge)
  • After merge, move the v1 floating tag and announce the runner-version requirement to customers

GitHub is forcing Node 24 on runners June 2 and removing Node 20
support on September 16. Both action.yml files declared
`using: node20`, which would break the action on that date.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ronens88 added a commit that referenced this pull request May 8, 2026
Backport of #115 to the v0 line. GitHub forces Node 24 on runners
June 2 and removes Node 20 support September 16, after which the
action would fail to start on Node-20-pinned runtimes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ronens88 added a commit that referenced this pull request May 10, 2026
Backport of #115 to the v0 line. GitHub forces Node 24 on runners
June 2 and removes Node 20 support September 16, after which the
action would fail to start on Node-20-pinned runtimes.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ronens88 ronens88 merged commit 198bedc into main May 10, 2026
5 checks passed
@ronens88 ronens88 deleted the chore/node24-bump branch May 10, 2026 07:11
ronens88 added a commit that referenced this pull request May 16, 2026
…38 upgrade (#118)

* ci: trigger verify-pr on PRs targeting release/v0

The v0 maintenance branch needs CI gating for backports like the
node24 bump (#116). Without this, PRs into release/v0 silently
skip the verify suite.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: bump action runtime to node24

Backport of #115 to the v0 line. GitHub forces Node 24 on runners
June 2 and removes Node 20 support September 16, after which the
action would fail to start on Node-20-pinned runtimes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(attest): Windows support in cimon-action/attest

When process.platform is win32 the action now fetches the
cimon_windows_x86_64.zip release asset from cycodelabs/cimon-releases
(rather than the Linux-only install.sh), extracts it to RUNNER_TEMP/cimon,
and invokes the resulting cimon.exe. Linux path is unchanged.

Adds @actions/tool-cache and @actions/http-client deps for cross-platform
download + zip extraction.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* build(attest): upgrade ncc to 0.38.4 for proper ESM/CJS interop on Node 24

* fix(attest): authenticate the latest-release lookup on Windows

The Windows path called https://api.github.com/repos/cycodelabs/cimon-releases/releases/latest
unauthenticated, which uses GitHub's per-IP REST limit (60 req/h).
Busy self-hosted runner fleets behind one egress IP can blow through
that and fail before cimon.exe is downloaded.

The action already accepts github-token (defaults to github.token);
plumb it through to the latest-release lookup as Bearer auth and pass
it to tc.downloadTool so private mirrors work too. Warn if no token is
present.

Reported by review on PR #118.

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants