Add support for magic properties#810
Open
danog wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting this to fully upstream changes in the valinor fork of one of my clients.
While currently Valinor does not make use of the new
magicPropertiesproperty, it is currently used by one of my clients to implement automatic type validation for their ORM, which relies exclusively on magic properties, specifically by taking all properties, compiling them via PropertyDefinitionCompiler::compile and storing them in a single static cache class, regenerated on every build.While I know this is technically using an
@internalAPI, the current caching options offered by Valinor are suboptimal in our case, where a simple static cache is enough , and much more performant than the alternatives.