Implement shaped lists#807
Open
danog wants to merge 25 commits into
Open
Conversation
# Conflicts: # src/Type/Parser/Lexer/Token/KeyOfToken.php # src/Type/Parser/Lexer/Token/ValueOfToken.php # tests/Integration/Mapping/ArrayValueOfMappingTest.php # tests/Integration/Mapping/KeyOfMappingTest.php # tests/Unit/Type/Parser/LexingParserTest.php
Contributor
Author
|
Ping @romm :) |
Member
|
Hi @danog, thanks for the submission. I did a bit of refactoring to use the same class to parse both (shaped) lists and arrays, to avoid a lot of duplicated logic which would have made the maintenance harder. |
Contributor
Author
|
Thanks, looks okay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also includes the key-of implementation to avoid conflicts since key-of also applies to shaped lists