Add support for Minecraft 26.2-snapshot-8 & Sulfur Caves#394
Open
linussztuka2011 wants to merge 22 commits into
Open
Add support for Minecraft 26.2-snapshot-8 & Sulfur Caves#394linussztuka2011 wants to merge 22 commits into
linussztuka2011 wants to merge 22 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for the new sulfur_caves biome alongside updating the embedded cubiomes submodule, and adjusts the Qt project build configuration for the subproject.
Changes:
- Add localized display name for the
sulfur_cavesbiome. - Include
sulfur_cavesin the “underground biomes” warning mask. - Update
cubiomessubmodule revision and tweak.probuild paths for building cubiomes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/util.cpp | Adds display-string mapping for the new biome ID. |
| src/conditiondialog.cpp | Treats sulfur_caves as an underground biome for warning logic. |
| cubiomes-viewer.pro | Changes cubiomes build path/make invocation to use relative paths. |
| cubiomes | Updates the cubiomes submodule commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
942
to
+946
| uint64_t underground = | ||
| (1ULL << (dripstone_caves-128)) | | ||
| (1ULL << (lush_caves-128)) | | ||
| (1ULL << (deep_dark-128)); | ||
| (1ULL << (deep_dark-128)) | | ||
| (1ULL << (sulfur_caves-128)); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…g cubiomes sources inline under MSVC
test: add automated integration test for sulfur_caves and MC_26_2_S8
…qt (#10) * Fix Windows build to bundle Qt DLLs using windeployqt * CI: install qttools for Windows windeployqt --------- Co-authored-by: Gemini (AI) <gemini-bot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* Initial plan * ci: fix ubuntu build by using distro Qt packages --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
…wn parameters (#13) Co-authored-by: Gemini (AI) <gemini-bot@users.noreply.github.com>
…es (#14) * Update cubiomes submodule to fix Woodland Mansion and Pale Garden spawn parameters * Fix sulfur_caves generation and filter out unassigned version gap ? entries in version selector --------- Co-authored-by: Gemini (AI) <gemini-bot@users.noreply.github.com>
- Add MC_26_2_S8 to the experimental versions filter in the UI. - Update the 'Locate biome center' condition to warn when searching for cave biomes at surface Y-levels. - Ensure Sulfur Caves are correctly recognized as an overworld cave biome for search validation. Co-authored-by: linussztuka2011 <220964708+linussztuka2011@users.noreply.github.com> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Modern versions of macOS require applications and their frameworks to be code-signed. Otherwise, they display a generic "damaged and can't be opened" error. By adding the `-codesign=-` option to `macdeployqt`, the Qt tool will apply an ad-hoc signature to the app bundle and everything it copies. Co-authored-by: linussztuka2011 <220964708+linussztuka2011@users.noreply.github.com> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
* Complete integration of MC_26_2_S8 and new biomes - Updated cubiomes library to include depth/scale parameters for 1.18+ biomes. - Refined isOverworld logic for new biomes. - Updated UI to correctly handle the new snapshot version in the version list. - Cleaned up submodule state and verified implementation with tests. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> * Fix Windows release build and complete biome integration - Fixed .github/workflows/build.yml to correctly build Windows binaries using MSVC and upload them as release assets. - Updated cubiomes library (submodule) with missing biome parameters and improved Overworld classification logic. - Updated viewer UI to hide the new snapshot version when experimental versions are disabled. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> * Fix Windows release pipeline and update biome logic for MC_26_2_S8 - Refactor `.github/workflows/build.yml` to fix Windows artifact creation and upload. - Use `ilammy/msvc-dev-cmd@v1` for robust MSVC setup. - Switch to `bash` shell and `7z` for Windows build and packaging. - Update `cubiomes` submodule with support for `sulfur_caves` biome and `MC_26_2_S8` version. - Filter out the new snapshot version from the UI dropdown in `src/mainwindow.cpp`. - Fix depth and scale parameters for 1.18+ biomes in `cubiomes/biomenoise.c`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> * Fix CI/CD builds and integrate MC_26_2_S8 biome logic - Switched Windows build shell to 'cmd' in build.yml to avoid link command conflicts. - Updated Windows packaging logic with '7z' and proper CMD syntax. - Integrated 'install-qt-action' for Linux builds to ensure environment consistency. - Improved executable discovery and archiving for both Linux and Windows artifacts. - Integrated 'sulfur_caves' biome and 'MC_26_2_S8' version support in cubiomes submodule and UI. - Verified biome generation with automated test tool. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> --------- Co-authored-by: linussztuka2011 <220964708+linussztuka2011@users.noreply.github.com> Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
* Initial plan * Fix Windows workflow linker selection * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Linus Sztuka <tbkids1.0@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds support for the newest Minecraft snapshot and the new sulfur_caves biome.
Added MC_26_2_S8 to version constants.
Registered sulfur_caves (ID 187) and its display colors/translations.
Added it to the underground biome mask to ensure proper UI warnings when searching at surface heights (Y > 246).
Note on generation parameters: The exact tmin, tmax, hmin parameter limits for sulfur_caves in 26.2-snapshot-8 are currently estimated using standard cave depth parameters (dmin = 1000, dmax = 9500) similar to dripstone/lush caves, to ensure stable generation until the noise offsets are fully reverse-engineered.