fix(connection): enable TCP nodelay by default#100
Open
yordis wants to merge 1 commit into
Open
Conversation
Small gRPC request/response messages were subject to Nagle's algorithm interacting with delayed ACKs, adding tens of milliseconds of latency to reads and appends. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodelayby default removes that latency for the common workload without requiring callers to hand-tunemint_opts.TCP_NODELAYby default: [DEV-1765] Set TCP_NODELAY on HttpConnector to disable Nagle's algorithm kurrent-io/KurrentDB-Client-Rust#233 (closing Missing TCP_NODELAY on HttpConnector causes ~40ms latency per gRPC call on localhost with in-memory kurrentdb kurrent-io/KurrentDB-Client-Rust#232).Closes #92