refactor: Remove unused introText keys from game configs#322
Open
jschhie wants to merge 2 commits into
Open
Conversation
- Deleted unused 'introText' keys across 36 game dicts
- Cleaned up database schema across all 52 games to align with pre-recorded 'introAudio' keys
(prev. generated TTS audio)
- Removed outdated game configs to improve maintainability/clarity
- Fixed minor typo: "their" to "its" in game description
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Hi @master-of-none, Could you please review these two PRs (#321 and #322) whenever you get a chance?
They can be merged in any order without conflicts. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
introTextconfig keys across 36 affected gamesImpact
introAudioassets (current human actors vs previous TTS audio)Approach
introTextentries fromgameConfigs.jsGames Affected (36 total)
Manual Tests
introAudiowithout relying on the deleted, TTS-basedintroTextNotes
introTextis withinuseGameCore.jsintroAudioto play pre-recordings and falls back to TTS audio usingintroTextif missing